tauri-plugin-deep-link icon indicating copy to clipboard operation
tauri-plugin-deep-link copied to clipboard

Published 20 hours ago • verified publisher icon FabianLars

Update template.desktop, Fixes #24

Open jojobyte opened this issue 1 year ago • 3 comments

NoDisplay=true prevents OS recognizing .desktop file and showing Handlers.

jojobyte avatar Mar 17 '23 19:03 jojobyte

Thanks for the PR, i'll try to get to it over the weekend! ❤️

I do have to search through my notes first though because there was i reason i added that line, hopefully i wrote that down somewhere 😅

One really quick search before turning off my computer led me to this page https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html which explicitly mentions this plugin's use case as an example for NoDisplay, which to me suggests that it could be a popos bug too 🤔

Also i'd imagine that this can cause conflicts with the actual main .desktop file of the app (showing up twice for example) but we'll see.

FabianLars avatar Mar 17 '23 20:03 FabianLars

One really quick search before turning off my computer led me to this page https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html which explicitly mentions this plugin's use case as an example for NoDisplay, which to me suggests that it could be a popos bug too thinking

Interesting. Maybe it is a popos bug. I think the biggest problem with the NoDisplay=true option is you dont get to see the handlers in the settings.

image

VS

image

Also i'd imagine that this can cause conflicts with the actual main .desktop file of the app (showing up twice for example) but we'll see.

You're correct there. I was assuming this one was supposed to override the default, not be along side it.

Now I can see this is working, however I don't like it not showing the Handlers. This is where I think the PR https://github.com/tauri-apps/tauri/pull/5180 would be useful so that its defined in both.

Not sure I understand the reasoning of why the .desktop file needs to change every time you open the program. Could you potentially elaborate or point me in the right direction so I can understand?

jojobyte avatar Mar 18 '23 04:03 jojobyte

Not sure I understand the reasoning of why the .desktop file needs to change every time you open the program. Could you potentially elaborate or point me in the right direction so I can understand?

That's mainly because we support .deb and appimages at the same time here, the physical location of appimages may change at any time so we also need to update the .desktop file accordingly :/

FabianLars avatar Mar 21 '23 11:03 FabianLars