FabMo-Engine icon indicating copy to clipboard operation
FabMo-Engine copied to clipboard

Update "System Variable Numbering"

Open tedh-shopbot opened this issue 3 years ago • 5 comments

We have carried over the ability to call up system variable in opensbp using %(var num).

At the moment, the specific numbering order is a hold-over from Sb3. Now would be a good time to make slight changes to the FabMo system to be more consistent with FabMo configs and better ordered. The numbering for the C axis and jerk values are some examples.

Relatively easy to change, but need to make sure well documented and as minimally different from sb3 as possible.

tedh-shopbot avatar Feb 15 '22 17:02 tedh-shopbot

What are the odds that it makes sense tro add "system variable aliases" i.e. that a system variable can be assessed as %(5000) or %(CurrentPositionOfQaxis) as well as reordering?

RobMackie avatar Mar 08 '22 17:03 RobMackie

Can we specify what changes we want to make in the text of this issue before we start making them?

RobMackie avatar May 10 '22 03:05 RobMackie

I don't understand the question. You quote an issue that is about a different topic (e.g. "user variables"). This issue topic is about the numbered "system variables".

It references the general matter of the overlap of how machine configuration items are managed between FabMo and G2 and about the matter that when OpenSBP was conceived we did not anticipate more than 4 axes so that there are now inconsistencies in how the numbering of system variables, which are sometimes also config variables, works.

The issue 882 is about user-named-variables of the &var and $var type and what we want to expose by way of allowing the user to manage them ... and as noted in the issue, we have one model in Josh's "Config App" that is installed in the dev-test profile.

tedh-shopbot avatar May 14 '22 15:05 tedh-shopbot

I think we need to talk about this. I can see you didn't understand my comment. I appreicate the specifics for what you think are the kinds of things that need changing. I can understand how numbering might be off as more axes have been added. Didn't know that was the issue. Are there other issues like that? can we enumerate them here?

RobMackie avatar May 15 '22 06:05 RobMackie

We probably need a conversation on this.

tedh-shopbot avatar May 18 '22 14:05 tedh-shopbot