RichTextFX icon indicating copy to clipboard operation
RichTextFX copied to clipboard

Published 20 hours ago • verified publisher icon FXMisc

Make it easier to implement EditableStyledDocument

Open JordanMartinez opened this issue 8 years ago • 3 comments

I'm filing this issue just to file it, not to try to solve it right now...

Currently, EditableStyledDocument is a hassle to implement (see Tomas' last few comments in #277). There are currently two quick ways we could make that it easier (though I'm not saying we should do this):

  • Make EditableStyledDocumentImpl public either temporarily until some better long-term solution is made or permanently.
  • Make StyledDocumentBase public. This will leave it up to the developer to only implement the new methods added in EditableStyledDocument.

JordanMartinez avatar Apr 05 '16 04:04 JordanMartinez

@TomasMikula in light of your recent commits (April 10 - April 11), how much easier is it to implement EditableStyledDocument? Or were your commits only to make the implementation more efficient?

JordanMartinez avatar Apr 12 '16 05:04 JordanMartinez

It was mainly about performance on large documents and simplification of the particular EditableStyledDocumentImpl implementation (it was reduced to about a half the number of lines).

TomasMikula avatar Apr 12 '16 05:04 TomasMikula

Due to Tomas' series of commits (b96f761f5175db95c9ebf781b45ad1db7667f1f3 to fcb53499e6706a7e44486df8729efbf9c9fe386f), making StyledDocumentBase public is no longer feasible.

JordanMartinez avatar Apr 18 '16 19:04 JordanMartinez