hlsdk-portable Fix killing tentacle in Blast Pit

Related https://github.com/FWGS/xash3d-fwgs/issues/1771

Aug 15 '24 10:08 a1batross

The commit in hlsdk-portable https://github.com/FWGS/hlsdk-portable/commit/f58544a1568f6abbbe28bf3c5c94b5b967e4f69c didn't change the gSizes to sizeof(EHANDLE) for FIELD_EHANDLE (unlike the halflife-updated https://github.com/twhl-community/halflife-updated/commit/d5d96d38830be1f9d41427c89d5a600fc778ff30). Could it be the culprit?

Aug 15 '24 11:08 FreeSlave

I've made a simple test map with multisource (it uses the array of EHANDLES). ms_test.zip

Press the first and the third button. Then save the game, reload and press the second button. The fourth button should become available for press now. But in hlsdk-portable it still denies the input.

Changing the gSizes fixes the situation.

Aug 15 '24 12:08 FreeSlave

Wouldn't it break compatibility with normal Half-Life save files?

I didn't try your solution yet...

Aug 18 '24 20:08 a1batross

It's for reading into memory. So it shouldn't. gInpusSizes define the sizes in the save file. gSizes define the sizes of variables in the memory.

Aug 18 '24 20:08 FreeSlave

Probably superseded by https://github.com/FWGS/hlsdk-portable/pull/467 now

But I'm not sure if we should change such things in the first place, if they tend to break existing games.

Aug 21 '24 12:08 a1batross