FTB-Chunks icon indicating copy to clipboard operation
FTB-Chunks copied to clipboard
verified publisher icon FTBTeam

[1.18] Fix block duplication due to separate Fabric BlockPlace and BlockRightClick events

Open zach2039 opened this issue 3 years ago • 4 comments

Fixes https://github.com/FTBTeam/FTB-Mods-Issues/issues/315.

Key changes:

  • Adds new protection, block_edit_and_interact, that is used on Fabric platforms instead of block_edit and block_interact, since we cannot differentiate block placement and block interact in Fabric Architectury.
  • Adds platform-dependent protection selection for events.

Tested in fabric dev environment on with server and two clients.

zach2039 avatar Jul 21 '22 14:07 zach2039

Hmm, if possible, I'd obviously like to see this properly resolved on the Architectury / Fabric side so we don't have to use more platform stuff than strictly necessary

MaxNeedsSnacks avatar Jul 21 '22 17:07 MaxNeedsSnacks

@MaxNeedsSnacks can you confirm if you plan on fixing this issue in Arch any time soon or should I pull this in until it's resolved your end?

MichaelHillcox avatar Jul 29 '22 15:07 MichaelHillcox

@zach2039 if you're still interested in getting this merged, could you please rebase it on the latest 1.18/dev branch ?

desht avatar Feb 02 '23 09:02 desht

Given the lack of response, I'm inclined to extract the code from this and manually patch it into Chunks. Needs doing since it does lead to a dupe on Fabric at the moment. If/when Architectury gets updated to better separate the concept of use and place, we can switch to that.

desht avatar Feb 07 '23 08:02 desht