FTB-Chunks icon indicating copy to clipboard operation
FTB-Chunks copied to clipboard

Fixes #375

Open vladislemon opened this issue 3 years ago • 4 comments

Fixes https://github.com/FTBTeam/FTB-Mods-Issues/issues/375

I'm not sure my solution is correct, waiting for review.

vladislemon avatar Jul 20 '22 06:07 vladislemon

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 20 '22 06:07 CLAassistant

A note for the future, please don't reformat code, I know it's likely your IDE that did the compression to a .* import so just a heads up if you make any future PR's. I'll review this PR in the coming days :+1:

MichaelHillcox avatar Jul 21 '22 16:07 MichaelHillcox

A note for the future, please don't reformat code, I know it's likely your IDE that did the compression to a .* import so just a heads up if you make any future PR's. I'll review this PR in the coming days +1

We should probably look into making an .editorconfig file or something for the mod repos, shouldn't we :P

MaxNeedsSnacks avatar Jul 21 '22 17:07 MaxNeedsSnacks

A note for the future, please don't reformat code, I know it's likely your IDE that did the compression to a .* import so just a heads up if you make any future PR's. I'll review this PR in the coming days +1

Fixed that.

vladislemon avatar Jul 22 '22 11:07 vladislemon

This PR needs to be raised against the 1.18/dev branch, not 1.18/main. (Merging into 1.18/main will kick off CI to publish a new build to Curseforge, which isn't desirable here)

desht avatar Nov 04 '22 17:11 desht

New PR: https://github.com/FTBTeam/FTB-Chunks/pull/229

vladislemon avatar Dec 10 '22 18:12 vladislemon