FTB-App icon indicating copy to clipboard operation
FTB-App copied to clipboard

[Feature request] Use of custom garbage collector (or other jvm args)

Open Joly0 opened this issue 2 years ago • 7 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I am trying to test out the shenandoah gc with various settings, though i am unable to change the default gc as it seems its hardcoded into the app here https://github.com/FTBTeam/FTB-App/blob/7b887cbdda58d647e9d3c4f1c5703315b6d4bff2/subprocess/src/main/java/net/creeperhost/creeperlauncher/Constants.java

Describe the solution you'd like A clear and concise description of what you want to happen.

I would like to be able to change the default options and test out gcs other then g1gc and aswell be able to overwrite all the other default jvm args.

A solution i have thought about would be removing the hardcoded default args and adding them to the settings.json in the .ftba\bin folder. Another solution would be, to just ignore the default args if custom ones are set per instance.

The first one would have the advantage of being able to adjust multiple instances at once, the later would help with problems each individual instance might have with new args.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Joly0 avatar Sep 24 '22 23:09 Joly0

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '22 00:10 stale[bot]

Still an issue

Joly0 avatar Oct 15 '22 13:10 Joly0

This issue / Pull request has been closed as there has been no recent activity after being marked as stale.

stale[bot] avatar Oct 22 '22 13:10 stale[bot]

?? This is still an issue

Joly0 avatar Oct 22 '22 23:10 Joly0

@MichaelHillcox Can this please get reopened?

Joly0 avatar Oct 23 '22 00:10 Joly0

The issue is still closed

Joly0 avatar Oct 23 '22 00:10 Joly0