karamel icon indicating copy to clipboard operation
karamel copied to clipboard

Fix karamel.opam: add ctypes and ctypes-foreign

Open cmovcc opened this issue 1 year ago • 7 comments

cmovcc avatar Oct 22 '23 21:10 cmovcc

Build fail, please try to see with @pnmadelaine what's up

msprotz avatar Oct 23 '23 02:10 msprotz

@pnmadelaine doesn't know what's going on -- @tahina-pro do you have a clue?

msprotz avatar Nov 13 '23 15:11 msprotz

Maybe @mtzguido knows?

msprotz avatar Dec 19 '23 17:12 msprotz

I think it's jump OPAM defaulting to no when installing dependencies. Trying..

mtzguido avatar Dec 19 '23 18:12 mtzguido

Sigh I think this is a discrepancy between the standalone build and the hierarchic one. The standalone build already does set OPAMYES=1, so the previous CI job from the original commit should have worked. The ones for my pushes just now are hierarchical (since there's an F* image on the machine), and seem to work even before my change (the merge is green).

I think the proper thing to do is removing the two flavors and just have one, but unsure on what that actually looks like if we want it to be fast. Also this should at least work around the problem if it shows up again.

diff --git a/.docker/standalone.Dockerfile b/.docker/standalone.Dockerfile
index d92931a0..b7c20531 100644
--- a/.docker/standalone.Dockerfile
+++ b/.docker/standalone.Dockerfile
@@ -12,6 +12,8 @@ RUN apt-get update && \
       git \
       gawk \
       coreutils \
+      libffi-dev \
+      pkg-config \
       sudo \
       opam \
       python3 \

mtzguido avatar Dec 19 '23 18:12 mtzguido

@cmovcc can I let you add Guido's patch to this PR? thanks!

msprotz avatar Dec 19 '23 18:12 msprotz

What's the status of this? Should it be merged?

msprotz avatar May 24 '24 17:05 msprotz