karamel icon indicating copy to clipboard operation
karamel copied to clipboard

Use POSIX-friendly syntax

Open concatime opened this issue 2 years ago • 3 comments

Hi, with this patch, I was able to compile Kremlin on a POSIX-friendly environment, which means:

  1. replace which by the POSIX command -v
  2. replace bash by POSIX sh

This helps a little bit more the build process by removing two dependencies.

concatime avatar Feb 14 '22 19:02 concatime

CLA assistant check
All CLA requirements met.

ghost avatar Feb 14 '22 19:02 ghost

Thanks for your contribution! Could you tell us a little bit why this is important? I buy the changes related to which, but why get rid of bash? This complicates the behavior in that we can't really rely on bash-like wildcard expansion which in turn means that, if we want to "do things right", we have to use $(wildcard ) a lot in Makefiles. Also, if you're building kremlin, surely you must have bash installed somewhere, no?

msprotz avatar Feb 14 '22 19:02 msprotz

On my local build, bash was not required, so I wrongly thought that I could simply swap it. That being said, from the CI (even tho I cannot access the log because it requries that I log-in with a Microsoft account, seriously?), it seems important. So yeah, you're right. I restored the SHELL to bash, and will install it on my machine.

concatime avatar Feb 14 '22 21:02 concatime