karamel
karamel copied to clipboard
Use POSIX-friendly syntax
Hi, with this patch, I was able to compile Kremlin on a POSIX-friendly environment, which means:
- replace
which
by the POSIXcommand -v
- replace
bash
by POSIXsh
This helps a little bit more the build process by removing two dependencies.
Thanks for your contribution! Could you tell us a little bit why this is important? I buy the changes related to which
, but why get rid of bash
? This complicates the behavior in that we can't really rely on bash-like wildcard expansion which in turn means that, if we want to "do things right", we have to use $(wildcard )
a lot in Makefiles. Also, if you're building kremlin, surely you must have bash installed somewhere, no?
On my local build, bash was not required, so I wrongly thought that I could simply swap it. That being said, from the CI (even tho I cannot access the log because it requries that I log-in with a Microsoft account, seriously?), it seems important. So yeah, you're right. I restored the SHELL
to bash, and will install it on my machine.