Max Bruckner comments

Results 139 comments of


                                            Max Bruckner

RFC(rumqttc): `publish` / `subscribe` / `unsubscribe` methods return a promise that resolves into pkid when packet is handled by `Eventloop`

I've rebased the `acked` branch onto `main` in #883. Currently this conflicts with the `FixedBitset` changes as mentioned by @xiaocq2001 which means I had to revert some of it. My...

opentelemetry::logs::AnyValue is missing a None variant

I can probably submit a PR within next week. Feel free to ping me again if it hasn't happened by then.

opentelemetry::logs::AnyValue is missing a None variant

Is there any reason why both `opentelemetry::Value` and `opentelemetry::logs::AnyValue` exist btw.? It seems to me that they should be the same type. (at least according to protocol buffers, they are...

opentelemetry::logs::AnyValue is missing a None variant

Ok, this also answers the next question I had, which is whether I should add `None` to `Value` as well, the answer is no: > Attribute values of null are...

WIP: Load texture positions (and more) from JSON

This stuff is quite prone to memory leaks, since it cannot be known which pointer points to a statically allocated resource and which at a dinamically allocated one. But as...

WIP: Load texture positions (and more) from JSON

Sorry for taking so long. I'm not sure when I am going to be able to continue with this.

Include path relative to the template file

This allows for better separation of code and templates. If the includes are relative to the directory where the template file is in, you can easily change the location of...

Don't output empty lines for control flow template arguments

Thanks for the feedback, I'll take a look at it.

Don't output empty lines for control flow template arguments

**My Ideas on implementing this feature (and refactor slt2 at the same time):** Instead of `precompile` and `include_fold` as well as some of the complexity in `loadstring`, there would be...

Don't output empty lines for control flow template arguments

> After parse, you will get a list of chunks. Then trim_blocks can be implemented by modifying normal text chunks before and after current template chunk. So no table of...