FSG_Mod_Assistant icon indicating copy to clipboard operation
FSG_Mod_Assistant copied to clipboard
verified publisher icon FSGModding

[VERSION TRACK] 6.0.0 Alpha Testing

Open jtsage opened this issue 1 year ago • 12 comments

Known Bugs - v6.0.0

This issue is an umbrella issue to keep track of bugs in the current version. You can reply directly here, but opening a new issue would make life easier for us.

6.0.0 is very, very alpha - there are rough edges all over. Apologies for yet another major version bump, but after a lot of consideration, the parser has been re-written in rust (tl;dr : it compiles to machine code, and in general testing is somewhere between 5x and 10x faster than the pure javascript parser.)

Known Issue List

  • [x] bunch of missing language keys, since added
  • [x] occasionally the category and brand listing in the main interface duplicates some items - fixed
  • [x] the old cache is invalid. the 5.9.80 build does not handle this, you have to manually rebuild. This step needs to be automated.
  • [x] some mods that passed the old parser fail the new one (bad xml prologue - the new parser is right, but the giants engine lets them through too - need to investigate relaxing the parser a little)
  • [x] copy function not working?
  • [ ] does onedrive sync mode still need to be there? The new parser does the UUID a little differently, did I already make a safe decision here?
  • [x] add trap for "none" brand (there is an image now, and it probably shouldn't display)
  • [x] basegame category list should ignore empty categories (this may fix all the missing images
  • [x] basegame "cartrailer" attachment not being picked up correctly
  • [x] ~~REGRESSION: none of the save manage buttons do the right thing. or at least not all of them do~~
  • [x] update main display, better layout for title/author/brand/categories
  • [x] malware detected crashes MA
  • [x] processing dialog not going away after version check/manage

jtsage avatar Nov 03 '24 00:11 jtsage

Version Testing

  • Starting SHA: 90cdf375e9cd4b2f77b0e43cef299e5f20f6a5b8

This is a list of all the functionality of FSG-MA

Folder Management

  • [x] Add Folder
  • [x] Remove Folder
  • [x] Missing Folder
  • [x] Offline Folder
  • [x] Drag New Folder
  • [x] Reorder folders
  • [x] Export CSV
  • [x] Set active (button)
  • [x] Set active (context)
  • [x] Set inactive
  • [x] Export as JSON (context)

File Management

  • [x] Drag file
  • [x] Drag ZIP of files
  • [x] Copy file - single destination
  • [x] Move file - single destination
  • [x] Copy file - multi destination
  • [x] Move file - multi destination
  • [x] Delete file
  • [x] Show in explorer
  • [x] Find on modhub
    • [x] No button if non-modhub
  • [x] Find on source website
  • [x] Copy favorites
  • [x] Export ZIP
  • [x] Open details

File Management - context menu

  • [x] Copy file - single destination
  • [x] Move file - single destination
  • [x] Copy file - multi destination
  • [x] Move file - multi destination
  • [x] Copy selected files - single destination
  • [x] Move selected files - single destination
  • [x] Copy selected files - multi destination
  • [x] Move selected files - multi destination
  • [x] Delete file
  • [x] Delete selected files
  • [x] Show in explorer
  • [x] Find on modhub
    • [x] No button if non-modhub
  • [x] Find on source website
    • [x] Set source website
    • [x] Un-Set source website
  • [x] Open details

Filters and Sorts

  • [x] sort modes work
  • [x] filter text works
  • [x] filter tags work
  • [x] select none
  • [x] select all
  • [x] select invert
  • [x] show only selected
  • [x] keyboard shortcuts for none/all/invert

File Operation

  • [x] no collection
  • [x] conflict present
  • [x] no conflict present
  • [x] select all/none/invert

Versions

  • [x] Button state
  • [x] Window opens and displays correct info
  • [x] Resolve function works

Detail page

  • [x] Vehicle type
  • [ ] Map Type
  • [x] Placeable type
  • [x] Production type

Basegame page

  • [x] Vehicle type
  • [x] Placeable type
  • [x] Production type

Savegame compare

  • [x] from button
  • [x] from dropped file
  • [x] from listed file
  • [x] select in main works
  • [x] filters work

Find window

  • [x] filter works
  • [x] select in main works

Savegame tracker

  • [x] opens
  • [x] respects version
  • [x] meaningful results

Savegame manage

  • [x] opens
  • [x] respects version
  • [x] import
  • [x] export
  • [x] duplicate
  • [x] remove
  • [x] compare

Game log

  • [x] opens
  • [x] respects version
  • [x] respects override
  • [x] scrolls well
  • [x] highlighting
  • [x] filtering
  • [x] find

Debug log

  • [x] opens
  • [x] filters

Collection details

  • [x] opens
  • [x] sets and reads properly

Preferences

  • [x] opens
  • [x] sets and reads properly
  • [x] clean cache
  • [x] clear cache
  • [x] clear malware
  • [x] font-size change
  • [x] theme change
  • [x] language change
  • [x] open changelog
  • [x] open wizard
  • [x] game settings - toggle dev mode

Extra UI buttons

  • [x] crowdin
  • [x] github
  • [x] FSG modding
  • [x] discord
  • [x] help
  • [x] launch button
    • [x] game poll respects version
  • [x] mini window
    • [x] mini window status updates
    • [x] mini window active collection
  • [x] minimize to tray
  • [x] tray launch game
  • [x] tray open mini
  • [x] change version

Import JSON

  • [x] read json file
  • [x] reject bad file
  • [x] download

jtsage avatar Nov 24 '24 16:11 jtsage

5.1.5: 0010 5.9.92-5.9.93: 0011

vitalii2011 avatar Jan 07 '25 09:01 vitalii2011

Huh. that's an odd one. can you send or paste %appdata%\fsg-mod-assistant\col_notes.json please?

jtsage avatar Jan 07 '25 14:01 jtsage

col_notes.json

vitalii2011 avatar Jan 07 '25 15:01 vitalii2011

Thanks. So, this is a dumb one that I didn't think through - basically, if a collection is old enough as far as MA is concerned, it may not have a version set in the col_notes.json file - and when I rolled the 6.0 changes, I changed the defaults of a lot of things from FS22 to FS25 - at any rate, the collection should still be in there, but it'll be in the FS25 section - you can alter the details of it from there, or if it's easier, play with %appdata%\fsg-mod-assistant\config.json - just remove that entry from the modFolders key and re-add it as usual, it will get the proper detail tags on re-add

jtsage avatar Jan 07 '25 15:01 jtsage

It didn't work or I did something wrong. I'm staying on v5.1.5, it suits me quite well, for which I thank you again. )

vitalii2011 avatar Jan 12 '25 09:01 vitalii2011

I think I'll probably revert the "not otherwise set" default for collections, that should put old stuff back where it was - and it's not possible to add a new collection without a game version (and hasn't been for a while), so it shouldn't affect future operation

jtsage avatar Jan 12 '25 15:01 jtsage

5.9.95: GIF

vitalii2011 avatar Jan 12 '25 19:01 vitalii2011

hmm. that's new. thank you, I'll figure out what the deal is there.

for reference, that's the disappearing/reappearing collection, right?

jtsage avatar Jan 12 '25 19:01 jtsage

Everything is fine with FS19.

vitalii2011 avatar Jan 12 '25 19:01 vitalii2011

I discovered an issue with copying FS25 favorites. I thought I was still on V5, but forgot I had pdated to the V6 beta. So, rather than fully redo what I found, I'll link to it instead. https://github.com/FSGModding/FSG_Mod_Assistant/issues/258#issuecomment-2692342088

Dylan-M avatar Mar 01 '25 17:03 Dylan-M

I discovered an issue with copying FS25 favorites. I thought I was still on V5, but forgot I had pdated to the V6 beta. So, rather than fully redo what I found, I'll link to it instead. https://github.com/FSGModding/FSG_Mod_Assistant/issues/258#issuecomment-2692342088

Saw it, thanks. Favorites aren't really version aware, it should just be grabbing the list of any and all mods in a favorite collection - it never occurred to me that it should care. I'll make that change.

jtsage avatar Mar 01 '25 18:03 jtsage