Formula-Student-Driverless-Simulator
Formula-Student-Driverless-Simulator copied to clipboard
FS-Driverless
Implemented a SetLocalPosition Service
Looks like I didn't use the latest version locally. I'll fix merge conflicts later
This looks great! Only thing left to do is add some documentation. After you resolve the conflicts I will test it :rocket:
Should all services be moved to fsds_msgs?
as Reset.srv was moved while the SetGPSPosition.srv and SetLocalPosition.srv definitions are still in fsds_ros_bridge
Should all services be moved to
fsds_msgs?
Yes! I think that would be the right way forward.
Tested it, works great!
I added a commit that removes the vehicle_name from SetLocalPosition.srv as FSDS only supports a single vehicle anyway. I also added the service file to the CMakeLists.txt because without it compilation failed.
Last thing to do is add a note in the docs. Let's also mention explicitly that setting the local position does not reset the velocity and also does not reset the command_controll.
Sorry, I didn't really have a lot of time in the past days.
Should all services be moved to fsds_msgs?
Yes! I think that would be the right way forward.
Do you want this to be done in this PR? Or in another PR after this one.
@MarvinKlemp We can do it in a separate pr :smile:
After you add some docs I we can merge :rocket: