cluster-broccoli icon indicating copy to clipboard operation
cluster-broccoli copied to clipboard

Published 20 hours ago • verified publisher icon FRosner

Fix/remove Docker tests

Open sohaibiftikhar opened this issue 6 years ago • 1 comments

The Docker tests currently require docker hub credentials and any contribution made from a fork fails the test making the CI not very reliable unless you look at the logs. Maybe we should push to docker hub only when a request is merged to master.

sohaibiftikhar avatar May 17 '18 19:05 sohaibiftikhar

Yes the Docker push should only be executed if the branch is NOT a pull request coming from external. I think Travis injects an environment variable to determine whether it's an internal branch or an external PR.

We cannot push only on master as we make use of the tags from branches for test deployments as well.

Would you like to make that change, @sohaibiftikhar?

FRosner avatar May 17 '18 19:05 FRosner