frr
frr copied to clipboard
Bgp tcp keepalive
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1374/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Failed
Checkout code: Failed (click for details)
PullReq merge failed. Please rebase your branch: see merge log in attachment https://ci1.netdef.org/browse/FRR-PULLREQ2-1374/artifact/CHECKOUT/ErrorLog/log_merge.txt
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1375/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1375/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1375/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:727:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:736:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1375/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1375/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Successful on other platforms/tests
- CentOS 8 amd64 build
- Fedora 29 amd64 build
- Ubuntu 18.04 arm8 build
- Debian 9 amd64 build
- Ubuntu 20.04 amd64 build
- Ubuntu 18.04 ppc64le build
- Debian 10 amd64 build
- Ubuntu 16.04 arm7 build
- CentOS 7 amd64 build
- Ubuntu 18.04 arm7 build
- Debian 11 amd64 build
- Ubuntu 16.04 i386 build
- Ubuntu 16.04 arm8 build
- Ubuntu 18.04 amd64 build
- FreeBSD 11 amd64 build
- Ubuntu 16.04 amd64 build
- FreeBSD 12 amd64 build
- NetBSD 8 amd64 build
- Ubuntu 18.04 i386 build
Warnings Generated during build:
Checkout code: Successful with additional warnings
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1375/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1375/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:727:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:736:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1375/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1375/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Report for bgp_network.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #239: FILE: /tmp/f1-600/bgp_network.c:239:
Report for bgp_vty.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2448: FILE: /tmp/f1-600/bgp_vty.c:2448:
< WARNING: line over 80 characters
< #2454: FILE: /tmp/f1-600/bgp_vty.c:2454:
Report for sockopt.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #718: FILE: /tmp/f1-600/sockopt.c:718:
< WARNING: line over 80 characters
< #727: FILE: /tmp/f1-600/sockopt.c:727:
< WARNING: please, no spaces at the start of a line
< #743: FILE: /tmp/f1-600/sockopt.c:743:
Outdated results 💚
Basic BGPD CI results: SUCCESS, 0 tests failed
| _ | _ |
|---|---|
| Result | SUCCESS git merge/9998 1b8bb947 |
| Date | 11/08/2021 |
| Start | 04:43:50 |
| Finish | 05:10:01 |
| Run-Time | 26:11 |
| Total | 1813 |
| Pass | 1813 |
| Fail | 0 |
| Valgrind-Errors | 0 |
| Valgrind-Loss | 0 |
| Details | vncregress-2021-11-08-04:43:50.txt |
| Log | autoscript-2021-11-08-04:45:04.log.bz2 |
| Memory | 518 515 405 |
For details, please contact louberger
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1383/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1383/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1383/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1383/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1383/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Successful on other platforms/tests
- Debian 10 amd64 build
- Ubuntu 16.04 arm7 build
- CentOS 7 amd64 build
- Debian 9 amd64 build
- Ubuntu 18.04 amd64 build
- Ubuntu 16.04 arm8 build
- FreeBSD 11 amd64 build
- Ubuntu 16.04 amd64 build
- Ubuntu 20.04 amd64 build
- Ubuntu 18.04 ppc64le build
- NetBSD 8 amd64 build
- FreeBSD 12 amd64 build
- Ubuntu 18.04 i386 build
- CentOS 8 amd64 build
- Ubuntu 18.04 arm7 build
- Fedora 29 amd64 build
- Debian 11 amd64 build
- Ubuntu 18.04 arm8 build
- Ubuntu 16.04 i386 build
Warnings Generated during build:
Checkout code: Successful with additional warnings
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1383/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1383/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1383/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1383/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Report for bgp_vty.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2447: FILE: /tmp/f1-1293/bgp_vty.c:2447:
Outdated results 💚
Basic BGPD CI results: SUCCESS, 0 tests failed
| _ | _ |
|---|---|
| Result | SUCCESS git merge/9998 cc71ef36 |
| Date | 11/08/2021 |
| Start | 06:16:45 |
| Finish | 06:43:00 |
| Run-Time | 26:15 |
| Total | 1813 |
| Pass | 1813 |
| Fail | 0 |
| Valgrind-Errors | 0 |
| Valgrind-Loss | 0 |
| Details | vncregress-2021-11-08-06:16:45.txt |
| Log | autoscript-2021-11-08-06:17:54.log.bz2 |
| Memory | 518 515 428 |
For details, please contact louberger
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1384/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1384/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1384/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c: CC lib/sockunion.lo
728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1384/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Successful on other platforms/tests
- Debian 10 amd64 build
- Ubuntu 16.04 arm7 build
- CentOS 7 amd64 build
- Ubuntu 18.04 i386 build
- Ubuntu 18.04 amd64 build
- Ubuntu 16.04 amd64 build
- FreeBSD 11 amd64 build
- Debian 9 amd64 build
- Ubuntu 20.04 amd64 build
- Ubuntu 16.04 arm8 build
- Ubuntu 18.04 ppc64le build
- NetBSD 8 amd64 build
- FreeBSD 12 amd64 build
- CentOS 8 amd64 build
- Ubuntu 16.04 i386 build
- Fedora 29 amd64 build
- Ubuntu 18.04 arm7 build
- Debian 11 amd64 build
- Ubuntu 18.04 arm8 build
Warnings Generated during build:
Checkout code: Successful with additional warnings
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1384/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1384/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c: CC lib/sockunion.lo
728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1384/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Report for bgp_vty.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2447: FILE: /tmp/f1-11373/bgp_vty.c:2447:
Outdated results 💚
Basic BGPD CI results: SUCCESS, 0 tests failed
| _ | _ |
|---|---|
| Result | SUCCESS git merge/9998 fd9318f7 |
| Date | 11/08/2021 |
| Start | 08:33:48 |
| Finish | 08:59:58 |
| Run-Time | 26:10 |
| Total | 1813 |
| Pass | 1813 |
| Fail | 0 |
| Valgrind-Errors | 0 |
| Valgrind-Loss | 0 |
| Details | vncregress-2021-11-08-08:33:48.txt |
| Log | autoscript-2021-11-08-08:35:01.log.bz2 |
| Memory | 519 516 427 |
For details, please contact louberger
A documentation update is missing.
doc added @ton31337
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1391/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1391/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1391/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1391/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1391/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Successful on other platforms/tests
- Ubuntu 16.04 arm7 build
- CentOS 7 amd64 build
- Ubuntu 18.04 arm7 build
- Debian 11 amd64 build
- Ubuntu 16.04 i386 build
- Ubuntu 16.04 arm8 build
- Ubuntu 18.04 amd64 build
- Ubuntu 16.04 amd64 build
- FreeBSD 11 amd64 build
- NetBSD 8 amd64 build
- FreeBSD 12 amd64 build
- Ubuntu 18.04 i386 build
- CentOS 8 amd64 build
- Fedora 29 amd64 build
- Ubuntu 18.04 arm8 build
- Debian 9 amd64 build
- Ubuntu 18.04 ppc64le build
- Ubuntu 20.04 amd64 build
- Debian 10 amd64 build
Warnings Generated during build:
Checkout code: Successful with additional warnings
OpenBSD 6 amd64 build: Failed (click for details)
OpenBSD 6 amd64 build: Unknown LogMake failed for OpenBSD 6 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1391/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.1391/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:9968: lib/sockopt.lo] Error 1
/home/ci/cibuild.1391/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1391/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Report for bgp_vty.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2447: FILE: /tmp/f1-4893/bgp_vty.c:2447:
Outdated results 💚
Basic BGPD CI results: SUCCESS, 0 tests failed
| _ | _ |
|---|---|
| Result | SUCCESS git merge/9998 b556a198 |
| Date | 11/08/2021 |
| Start | 09:59:36 |
| Finish | 10:25:54 |
| Run-Time | 26:18 |
| Total | 1813 |
| Pass | 1813 |
| Fail | 0 |
| Valgrind-Errors | 0 |
| Valgrind-Loss | 0 |
| Details | vncregress-2021-11-08-09:59:36.txt |
| Log | autoscript-2021-11-08-10:00:52.log.bz2 |
| Memory | 498 491 428 |
For details, please contact louberger
1. No form of the command
no form is added
2. What should happen when I change the values of a pre-existing connection
pre-existing connections are not refreshed with new tcp keepalive settings. I can add some printf info for that
3. Topotest please
a topotest suite to test tcp connection ? I can, but I mean, what I offer here is just an api to configure tcp keepalive at system level.
@pguibert6WIND we should skip OpenBSD when setting this socket option?
This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.
@pguibert6WIND we should skip OpenBSD when setting this socket option?
I think TCP keepalive can be configured, but not with the specific timer settings.
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6706/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
OpenBSD 7 amd64 build: Failed (click for details)
OpenBSD 7 amd64 build: Unknown LogMake failed for OpenBSD 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6706/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.6706/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:10373: lib/sockopt.lo] Error 1
ospf6d/ospf6_interface.c:970:1: warning: Time to remove ospf6Enabled from JSON output [-W#pragma-messages]
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
Successful on other platforms/tests
- Ubuntu 16.04 arm8 build
- Ubuntu 18.04 amd64 build
- Debian 11 amd64 build
- Ubuntu 18.04 i386 build
- NetBSD 9 amd64 build
- Ubuntu 18.04 arm7 build
- Ubuntu 16.04 amd64 build
- CentOS 7 amd64 build
- Ubuntu 16.04 i386 build
- FreeBSD 12 amd64 build
- Fedora 29 amd64 build
- Ubuntu 20.04 amd64 build
- Ubuntu 18.04 arm8 build
- Debian 9 amd64 build
- Redhat 8 amd64 build
- Redhat 9 amd64 build
- Debian 10 amd64 build
- Ubuntu 18.04 ppc64le build
- Ubuntu 16.04 arm7 build
- Ubuntu 22.04 amd64 build
- FreeBSD 11 amd64 build
Warnings Generated during build:
Checkout code: Successful with additional warnings
OpenBSD 7 amd64 build: Failed (click for details)
OpenBSD 7 amd64 build: Unknown LogMake failed for OpenBSD 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6706/artifact/CI011BUILD/ErrorLog/log_make.txt)
gmake all-am
gmake[1]: Entering directory '/home/ci/cibuild.6706/frr-source'
lib/sockopt.c:718:36: error: use of undeclared identifier 'TCP_KEEPIDLE'
lib/sockopt.c:728:36: error: use of undeclared identifier 'TCP_KEEPINTVL'
lib/sockopt.c:738:36: error: use of undeclared identifier 'TCP_KEEPCNT'
3 errors generated.
gmake[1]: *** [Makefile:10373: lib/sockopt.lo] Error 1
ospf6d/ospf6_interface.c:970:1: warning: Time to remove ospf6Enabled from JSON output [-W#pragma-messages]
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
Report for bgp_vty.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2579: FILE: /tmp/f1-32506/bgp_vty.c:2579:
Continuous Integration Result: SUCCESSFUL
Continuous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF / OpenSourceRouting.org CI System
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6707/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Warnings Generated during build:
Checkout code: Successful with additional warnings
Report for bgp_vty.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2579: FILE: /tmp/f1-30667/bgp_vty.c:2579:
Continuous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF / OpenSourceRouting.org CI System
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7175/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.