frr icon indicating copy to clipboard operation
frr copied to clipboard

zebra: add mpls configuration knob per interface

Open pguibert6WIND opened this issue 4 years ago • 25 comments

This configuration knob permits to set value of : proc/sys/net/mpls/conf//input. Even if underlying interface is not available at the moment of the call.

Signed-off-by: Philippe Guibert [email protected]

pguibert6WIND avatar Aug 27 '21 14:08 pguibert6WIND

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9505 9c0a6546
Date 08/27/2021
Start 10:11:02
Finish 10:37:24
Run-Time 26:22
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-27-10:11:02.txt
Log autoscript-2021-08-27-10:12:14.log.bz2
Memory 512 490 425

For details, please contact louberger

LabN-CI avatar Aug 27 '21 14:08 LabN-CI

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9505 607f0186
Date 08/27/2021
Start 11:16:04
Finish 11:42:25
Run-Time 26:21
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-27-11:16:04.txt
Log autoscript-2021-08-27-11:17:16.log.bz2
Memory 490 514 425

For details, please contact louberger

LabN-CI avatar Aug 27 '21 15:08 LabN-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21429/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for interface.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-15746/interface.c:65:
< WARNING: Missing a blank line after declarations
< #3856: FILE: /tmp/f1-15746/interface.c:3856:
< WARNING: line over 80 characters
< #4245: FILE: /tmp/f1-15746/interface.c:4245:

NetDEF-CI avatar Aug 27 '21 17:08 NetDEF-CI

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21431/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9DEB10AMD64-21431/test

Topology Tests failed for Topotests debian 10 amd64 part 9:

2021-08-27 15:53:38,458 ERROR: assert failed at "test_ospf_asbr_summary_topo1/test_ospf_type5_summary_tc48_p0": Testcase test_ospf_type5_summary_tc48_p0 : FailedError: Summary missing in OSPF DB
assert '[DUT: r0] OSPF summary 11.0.0.0/8 : External route count is 0, Expected is 5' is True
2021-08-27 15:57:34,682 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-08-27 15:57:57,177 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-08-27 16:03:46,731 ERROR: r0: bgpd left a dead pidfile (pid=1985)
2021-08-27 16:08:37,526 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-08-27 16:08:56,949 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21431/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-21431/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9:

2021-08-27 15:58:00,500 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-08-27 15:58:23,216 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-08-27 16:02:07,901 ERROR: r3: bgpd left a dead pidfile (pid=8293)
2021-08-27 16:09:26,343 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-08-27 16:09:45,305 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 


2021-08-27 16:40:45,365 ERROR: assert failed at "test_ospfv3_asbr_summary_topo1/test_ospfv3_type5_summary_tc46_p0": Testcase test_ospfv3_type5_summary_tc46_p0 : Failed 
   Error: Routes still present in OSPF RIB True
assert True is not True
2021-08-27 16:48:10,528 ERROR: h1: zebra left a dead pidfile (pid=30266)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21431/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 1
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 amd64 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 3
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 6
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 20.04 deb pkg check
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 5
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 i386 part 4
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 4
  • Static analyzer (clang)

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9DEB10AMD64-21431/test

Topology Tests failed for Topotests debian 10 amd64 part 9:

2021-08-27 15:53:38,458 ERROR: assert failed at "test_ospf_asbr_summary_topo1/test_ospf_type5_summary_tc48_p0": Testcase test_ospf_type5_summary_tc48_p0 : FailedError: Summary missing in OSPF DB
assert '[DUT: r0] OSPF summary 11.0.0.0/8 : External route count is 0, Expected is 5' is True
2021-08-27 15:57:34,682 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-08-27 15:57:57,177 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-08-27 16:03:46,731 ERROR: r0: bgpd left a dead pidfile (pid=1985)
2021-08-27 16:08:37,526 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-08-27 16:08:56,949 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21431/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-21431/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9:

2021-08-27 15:58:00,500 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-08-27 15:58:23,216 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-08-27 16:02:07,901 ERROR: r3: bgpd left a dead pidfile (pid=8293)
2021-08-27 16:09:26,343 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-08-27 16:09:45,305 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 


2021-08-27 16:40:45,365 ERROR: assert failed at "test_ospfv3_asbr_summary_topo1/test_ospfv3_type5_summary_tc46_p0": Testcase test_ospfv3_type5_summary_tc46_p0 : Failed 
   Error: Routes still present in OSPF RIB True
assert True is not True
2021-08-27 16:48:10,528 ERROR: h1: zebra left a dead pidfile (pid=30266)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21431/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Report for interface.c | 4 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-11029/interface.c:65:
< WARNING: line over 80 characters
< #4247: FILE: /tmp/f1-11029/interface.c:4247:

NetDEF-CI avatar Aug 27 '21 18:08 NetDEF-CI

ci.rerun

pguibert6WIND avatar Aug 28 '21 14:08 pguibert6WIND

ci:rerun

pguibert6WIND avatar Aug 28 '21 19:08 pguibert6WIND

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21446/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for interface.c | 4 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-14203/interface.c:65:
< WARNING: line over 80 characters
< #4247: FILE: /tmp/f1-14203/interface.c:4247:

NetDEF-CI avatar Aug 28 '21 22:08 NetDEF-CI

Documentation changes?

ton31337 avatar Aug 29 '21 08:08 ton31337

@polychaeta rereview

qlyoung avatar Aug 30 '21 02:08 qlyoung

I recall a discussion with Donald, where I was questioning whether configure mpls sysctl on vty was ok , could be accepted on upstream. So this is the implem 1 I propose. I think of an other implem: automatic mode, where mpls flag would be set automatically based on the routes detected on zebra. With some guidance, I could probably implem that automatic mode.

pguibert6WIND avatar Aug 30 '21 10:08 pguibert6WIND

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9505 b6b18524
Date 08/30/2021
Start 06:31:02
Finish 06:57:27
Run-Time 26:25
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-30-06:31:02.txt
Log autoscript-2021-08-30-06:32:20.log.bz2
Memory 513 531 420

For details, please contact louberger

LabN-CI avatar Aug 30 '21 10:08 LabN-CI

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9505 ee59c75b
Date 08/30/2021
Start 07:01:03
Finish 07:27:23
Run-Time 26:20
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-30-07:01:03.txt
Log autoscript-2021-08-30-07:02:20.log.bz2
Memory 500 512 424

For details, please contact louberger

LabN-CI avatar Aug 30 '21 11:08 LabN-CI

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9505 d9aa0a57
Date 08/30/2021
Start 08:26:01
Finish 08:52:18
Run-Time 26:17
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-30-08:26:01.txt
Log autoscript-2021-08-30-08:27:13.log.bz2
Memory 514 450 417

For details, please contact louberger

LabN-CI avatar Aug 30 '21 12:08 LabN-CI

@qlyoung, what Donald does is the netlink part of configuring MPLS flag. I think this piece of code can be brought in for now, then later, the config hooks will be mapped to netlink api.

pguibert6WIND avatar Aug 30 '21 13:08 pguibert6WIND

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21459/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 8: Incomplete (check logs for details)
Successful on other platforms/tests
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 2
  • Ubuntu 16.04 deb pkg check
  • Topotests debian 10 amd64 part 7
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 8
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests debian 10 amd64 part 3
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 i386 part 4
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Fedora 29 rpm pkg check
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 0
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 0
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 5
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 4

NetDEF-CI avatar Aug 30 '21 13:08 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21460/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for interface.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-16664/interface.c:65:
< WARNING: space prohibited between function name and open parenthesis '('
< #3773: FILE: /tmp/f1-16664/interface.c:3773:
< WARNING: line over 80 characters
< #4242: FILE: /tmp/f1-16664/interface.c:4242:

NetDEF-CI avatar Aug 30 '21 13:08 NetDEF-CI

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21461/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Successful on other platforms/tests
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 16.04 deb pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 6
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 5
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 4
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 5
  • IPv6 protocols on Ubuntu 18.04
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 1
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 5
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 6
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Report for interface.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-26331/interface.c:65:
< WARNING: space prohibited between function name and open parenthesis '('
< #3773: FILE: /tmp/f1-26331/interface.c:3773:
< WARNING: line over 80 characters
< #4242: FILE: /tmp/f1-26331/interface.c:4242:

NetDEF-CI avatar Aug 30 '21 14:08 NetDEF-CI

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9505 2bdccfa7
Date 08/30/2021
Start 09:47:22
Finish 10:13:41
Run-Time 26:19
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-30-09:47:22.txt
Log autoscript-2021-08-30-09:48:42.log.bz2
Memory 487 515 426

For details, please contact louberger

LabN-CI avatar Aug 30 '21 14:08 LabN-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21465/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for interface.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-21476/interface.c:65:
< WARNING: space prohibited between function name and open parenthesis '('
< #3773: FILE: /tmp/f1-21476/interface.c:3773:
< WARNING: line over 80 characters
< #4242: FILE: /tmp/f1-21476/interface.c:4242:

NetDEF-CI avatar Aug 30 '21 15:08 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21466/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for interface.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-31769/interface.c:65:
< WARNING: space prohibited between function name and open parenthesis '('
< #3775: FILE: /tmp/f1-31769/interface.c:3775:
< WARNING: line over 80 characters
< #4244: FILE: /tmp/f1-31769/interface.c:4244:

NetDEF-CI avatar Aug 30 '21 15:08 NetDEF-CI

Docs are missing

I updated doc/../zebra.rst file.

pguibert6WIND avatar Sep 03 '21 14:09 pguibert6WIND

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9505 cca9940d
Date 09/03/2021
Start 11:35:19
Finish 12:01:27
Run-Time 26:08
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-09-03-11:35:19.txt
Log autoscript-2021-09-03-11:36:28.log.bz2
Memory 513 463 426

For details, please contact louberger

LabN-CI avatar Sep 03 '21 16:09 LabN-CI

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21583/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for interface.c | 6 issues
===============================================
< WARNING: externs should be avoided in .c files
< #65: FILE: /tmp/f1-16508/interface.c:65:
< WARNING: space prohibited between function name and open parenthesis '('
< #3775: FILE: /tmp/f1-16508/interface.c:3775:
< WARNING: line over 80 characters
< #4244: FILE: /tmp/f1-16508/interface.c:4244:

NetDEF-CI avatar Sep 03 '21 18:09 NetDEF-CI

@frrbot rereview

qlyoung avatar Sep 14 '21 15:09 qlyoung

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

github-actions[bot] avatar Jul 09 '22 02:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 13 '22 13:10 github-actions[bot]

already merged by an other pull request

pguibert6WIND avatar May 23 '23 06:05 pguibert6WIND