This implements:

announcing the router's own addresses as /128 prefix in the Router LSA with the LA bit set (this is a prerequisite for implementing virtual link support too, since this is how the IPv6 address for the other router is found)
adds a ipv6 ospf6 neighbor X:X::X:X list under each interface, with cost and poll-interval settings each
ipv6 ospf6 p2p-p2mp disable-multicast-hello knob does what the label says
ipv6 ospf6 p2p-p2mp config-neighbors-only refuses becoming neighbor/adjacent with routers that aren't in the ipv6 ospf6 neighbor list
ipv6 ospf6 p2p-p2mp connected-prefixes <include|exclude> the semantically trickiest one (though code-wise extremely simple) controls whether addresses on the ptp/ptmp interface are announced as /128 or as /128 + (/64 or other prefix len)
ipv6 ospf6 network point-to-multipoint, finally, just changes from multicast to unicast for LSDB flooding & updates

User doc should explain everything.

Not fully tested yet, hence draft PR. Tests coming up soon™.

Jul 27 '21 16:07 eqvinox

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9198 4f496455
Date	07/27/2021
Start	14:52:51
Finish	15:18:27
Run-Time	25:36
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-27-14:52:51.txt
Log	autoscript-2021-07-27-14:54:07.log.bz2
Memory	501 502 414

For details, please contact louberger

Jul 27 '21 19:07 LabN-CI

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20579/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for ospf6_interface.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2526: FILE: /tmp/f1-1084/ospf6_interface.c:2526:
Report for ospf6_neighbor.c | 6 issues
===============================================
< WARNING: Missing a blank line after declarations
< #787: FILE: /tmp/f1-1084/ospf6_neighbor.c:787:
< WARNING: space prohibited between function name and open parenthesis '('
< #822: FILE: /tmp/f1-1084/ospf6_neighbor.c:822:
< WARNING: space prohibited between function name and open parenthesis '('
< #1536: FILE: /tmp/f1-1084/ospf6_neighbor.c:1536:

CLANG Static Analyzer Summary

Github Pull Request 9198, comparing to Git base SHA 42ac787
Base image data for Git 42ac787 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20579/artifact/shared/static_analysis/index.html

Jul 27 '21 22:07 NetDEF-CI

topotests and SA issue introduced

Jul 28 '21 14:07 donaldsharp

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20717/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch: see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20717/artifact/CHECKOUT/ErrorLog/log_merge.txt

Aug 02 '21 15:08 NetDEF-CI

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/9198 801f69fd0 (merge failed)
Date	08/02/2021
Start	11:51:30
Finish	12:17:06
Run-Time	25:36
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-08-02-11:51:30.txt
Log	autoscript-2021-08-02-11:52:50.log.bz2
Memory	495 491 414

For details, please contact louberger

Aug 02 '21 16:08 LabN-CI

(I'm aware this needs to be rebased. It's a DRAFT. I pushed it out for visibility and to avoid duplicate work. Due to priorities/resource allocations, this is probably going to sit here for a bit.)

Aug 04 '21 13:08 eqvinox

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9198 7bd5f0d90
Date	08/27/2021
Start	06:06:03
Finish	06:32:29
Run-Time	26:26
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-08-27-06:06:03.txt
Log	autoscript-2021-08-27-06:07:17.log.bz2
Memory	517 515 424

For details, please contact louberger

Aug 27 '21 10:08 LabN-CI

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21424/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for ospf6_interface.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2554: FILE: /tmp/f1-16854/ospf6_interface.c:2554:
Report for ospf6_neighbor.c | 6 issues
===============================================
< WARNING: Missing a blank line after declarations
< #811: FILE: /tmp/f1-16854/ospf6_neighbor.c:811:
< WARNING: space prohibited between function name and open parenthesis '('
< #846: FILE: /tmp/f1-16854/ospf6_neighbor.c:846:
< WARNING: space prohibited between function name and open parenthesis '('
< #1560: FILE: /tmp/f1-16854/ospf6_neighbor.c:1560:

CLANG Static Analyzer Summary

Github Pull Request 9198, comparing to Git base SHA 3e386e9
Base image data for Git 3e386e9 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21424/artifact/shared/static_analysis/index.html

Aug 27 '21 13:08 NetDEF-CI

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Oct 13 '22 13:10 github-actions[bot]

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9625/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-9625/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9625/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-9625/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9625/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 9: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9625/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9625/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Static analyzer (clang)
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0