frr icon indicating copy to clipboard operation
frr copied to clipboard

Add IPv6 support for ip import-table

Open marek22k opened this issue 1 month ago • 4 comments

marek22k avatar Nov 28 '25 06:11 marek22k

I have never created a Topotest before, but I will give it a try. I would simply use one of the existing tests as a basis - that should be allowed, since everything is under the same license.

marek22k avatar Nov 28 '25 22:11 marek22k

I have now written a test that works on my local Docker container. Regarding the documentation, I am unsure how to document this in a "nice" or elegant way, or where the appropriate place for it is in the documentation. If you would like me to change it again, please let me know.

marek22k avatar Nov 28 '25 23:11 marek22k

This looks good to me now, modulus the one nit I have. We'll get this in once the topotest is fixed. Thanks!

donaldsharp avatar Nov 29 '25 14:11 donaldsharp

@ton31337 @donaldsharp Are there still blockers?

marek22k avatar Dec 07 '25 22:12 marek22k

Ping @ton31337 @donaldsharp @riw777

marek22k avatar Dec 13 '25 14:12 marek22k

@ton31337 @donaldsharp @riw777 If there are no further issues, perhaps the PR can be merged?

marek22k avatar Dec 19 '25 23:12 marek22k

Ping @ton31337 @nabahr @donaldsharp @riw777 Can the PR be merged?

marek22k avatar Dec 23 '25 11:12 marek22k

@ton31337 Thanks for the review. I have changed the lines except for the additional validation.

marek22k avatar Dec 23 '25 12:12 marek22k

@github-actions I rebased it.

marek22k avatar Dec 23 '25 12:12 marek22k