FRRouting
pimd: Suppress misleading valgrind memory leak
Add new valgrind suppression for a memory leak in pimd that is not a real memory leak.
Please - put some text in the description explaining what you are changing here?
Add new valgrind suppression for a memory leak in pimd that is not a real memory leak.
Ha ha ha.
Wishful thinking. Try "a real leak that we can't be bothered plugging".
@paulfloyd Your certainly welcome to contribute to the community but comments like this are not really helpful or wanted. If you have a code suggestion please feel free to bring it forward.
@paulfloyd Your certainly welcome to contribute to the community but comments like this are not really helpful or wanted. If you have a code suggestion please feel free to bring it forward.
If it's "not a real memory leak" then you should report it to https://bugs.kde.org. I'm always looking for genuine false positives. This doesn't look like one.
It's memory that is allocated prior to a fork, the child frees it later but the parent quits immediately without freeing it as far as I can tell. Valgrind is reporting that this is a memory leak in the parent process. One thought was to choose to ignore this for the moment via a valgrind suppression. We just didn't put that level of detail in the PR because all the people important to the discussion are talking about this outside of github. This doesn't change my point, though that you need to find better ways to express yourself without coming off as condescending.
Well I do think that you should be a bit more honest about why you are suppressing leaks.