frr icon indicating copy to clipboard operation
frr copied to clipboard

bfdd: disable echo socket when not using it

Open rzalamena opened this issue 1 year ago • 3 comments

Fixes #16594.

Lets avoid a performance penalty in forwarding when not using the BFD echo feature. The echo socket uses raw packet capturing along with a BPF filter which causes performance issues.

rzalamena avatar Oct 02 '24 20:10 rzalamena

once ci finishes I'll get this in.

donaldsharp avatar Oct 03 '24 15:10 donaldsharp

looks like closing this socket is causing bfdd not to be able to "find itself" ... the test probably needs to be changed (?)

riw777 avatar Oct 08 '24 14:10 riw777

ci:rerun

RodrigoMNardi avatar Oct 19 '24 00:10 RodrigoMNardi

I can confirm that the change helps. I backported the commit to 10.1.1. With running bfdd, creating 250 VRFs does not produce noticeable impact on the network throughput.

Thanks @rzalamena !

crosser avatar Oct 21 '24 11:10 crosser

It's odd it's only failing on docker ... let's try again

ci:rerun

riw777 avatar Nov 05 '24 15:11 riw777

I think the CI test needs to be looked at ... probably not going to pass ...

riw777 avatar Nov 12 '24 13:11 riw777