frr icon indicating copy to clipboard operation
frr copied to clipboard

vlan-subif isis neigbor

Open JosiahMg opened this issue 1 year ago • 10 comments

When I use the ip link add command on two Ubuntu systems to create an eth1.100 VLAN sub-interface and enable the ISIS protocol on the interface, I find that the sub-interface can not only establish an ISIS neighbor with the eth1.100 port of another Ubuntu, but also establish an ISIS neighbor with the eth1 port.

ip link add link eth1 name eth1.100 type vlan 100

R1 configuration:

interface eth1
  ip route isis 1
interface eth1.100
  ip route isis 1
router isis 1
  is-type level-2-only
  net 49.0000.0000.0001.00

R2 configuration:

interface eth1.100
  ip route isis 1
router isis 1
  is-type level-2-only
  net 49.0000.0000.0001.00

R1 show isis neighbor

SystemID     Interface      L     State
R2                  eth1           2       UP
R2                  eth1.100    2       UP

R2 show isis neighbor

SystemID     Interface      L     State
R1                  eth1.100    2       UP

JosiahMg avatar Jul 27 '24 13:07 JosiahMg

let's rebase and force push, we only want commits related to what is being changed in the branch.

donaldsharp avatar Jul 29 '24 12:07 donaldsharp

Please drop merge commits, and follow our contribution guidelines: https://github.com/FRRouting/frr/blob/master/doc/developer/workflow.rst#submitting-patches-and-enhancements

ton31337 avatar Jul 30 '24 12:07 ton31337

yep as Donatas says please drop the merge commits

donaldsharp avatar Jul 30 '24 17:07 donaldsharp

yep as Donatas says please drop the merge commits

On GitHub.com, navigate to the main page of the repository, I have dropped "merge commit" in the setting of the navigation bar, but I don't know if it will work.

JosiahMg avatar Jul 31 '24 01:07 JosiahMg

@JosiahMg you have to squash all your commits into a single one.

ton31337 avatar Jul 31 '24 09:07 ton31337

This is not a github operation. In the workspace you have the pull:

git pull git rebase git push --force

donaldsharp avatar Jul 31 '24 13:07 donaldsharp

@JosiahMg you have to squash all your commits into a single one.

Thanks, I've dealt with it

JosiahMg avatar Aug 01 '24 01:08 JosiahMg

@donaldsharp Thanks, it has been handled as you said

JosiahMg avatar Aug 01 '24 01:08 JosiahMg

@donaldsharp can you look again and see if we can pull the blocker? :-)

riw777 avatar Aug 14 '24 22:08 riw777

@donaldsharp ping ... :-)

riw777 avatar Aug 27 '24 14:08 riw777

@donaldsharp ping ... :-)

riw777 avatar Sep 24 '24 13:09 riw777

@donaldsharp can we clear the blocker on this? :-)

riw777 avatar Oct 22 '24 11:10 riw777