frr icon indicating copy to clipboard operation
frr copied to clipboard

isisd: The neighbor entry still displays the deleted hostname of the neighbor.

Open zhou-run opened this issue 1 year ago • 4 comments

  1. The lsp_update_data() function will check for the presence of the ISIS_TLV_DYNAMIC_HOSTNAME in the LSP, and then call isis_dynhn_insert() to add a hostname entry corresponding to the LSP ID. However, when the ISIS_TLV_DYNAMIC_HOSTNAME is not present in the LSP, the hostname entry corresponding to the LSP ID should also be deleted.
  2. The command “show isis neighbor” invokes isis_adj_name() to display the System ID or hostname, but it does not check the area->dynhostname flag.

Signed-off-by: zhou-run [email protected]

zhou-run avatar Jun 19 '24 09:06 zhou-run

Seems that tests should be updated/fixed too.

ton31337 avatar Jun 20 '24 08:06 ton31337

Seems that tests should be updated/fixed too.

Yes, I am currently investigating why the hostname entry is being lost in the case of the area->dynhostname being enabled.

zhou-run avatar Jun 20 '24 08:06 zhou-run

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 21 '24 06:06 github-actions[bot]

@frrbot rereview

ton31337 avatar Jun 25 '24 05:06 ton31337

failing in ospf; rerunning just the failed tests to see if we can clear them

riw777 avatar Jul 09 '24 03:07 riw777