frr
frr copied to clipboard
FRRouting
isisd: Three-Way Handshake State Change from Expiring
Under certain conditions the ISIS three-way handshake becomes stuck in an 'Expiring' mode and does not clear the neighbor entry. This fix will clear the neighbor entry if this condition becomes true.
@aceelindem Valid point - I can do another commit for the Broadcast circuit type.
I'm okay with a separate commit for broadcast type ... should we open an issue to track it?
I'm okay with a separate commit for broadcast type ... should we open an issue to track it?
I'm okay if you are. Do we need issues for every fix? I haven't been opening them.
Looks good. Normally, you'd squash the two commits though.
I'm okay with a separate commit for broadcast type ... should we open an issue to track it?
I'm okay if you are. Do we need issues for every fix? I haven't been opening them.
nah ... just don't want to forget this additional work needs to be done ...
Looks good. Normally, you'd squash the two commits though.
I'm okay with a separate commit for broadcast type ... should we open an issue to track it?
I'm okay if you are. Do we need issues for every fix? I haven't been opening them.
nah ... just don't want to forget this additional work needs to be done ...
Looks good. Normally, you'd squash the two commits though.
I'm okay with a separate commit for broadcast type ... should we open an issue to track it?
I'm okay if you are. Do we need issues for every fix? I haven't been opening them.
nah ... just don't want to forget this additional work needs to be done ...
The second commit commit handles the broadcast circuit. It is just not squashed - which I agree is ok.
please fix the lints, and then we can try to figure the failures out ... thanks!
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
failing in ospf single switch test ... reunning just the failure to see if we can clear this
failing in ospf single switch test ... reunning just the failure to see if we can clear this
I've seen this failure on PRs as well - I think it is related to the topotest using 8 routers.
please rebase to and let's see if that fixes this ci failure we also need to clear the conflicts now ... :-(
When i did the rebase i got a conflict and found that a previous commit has actually dealt with this same issue.
https://github.com/FRRouting/frr/commit/5009f7539ad6bf496158499917dcf3f7ab760753