frr icon indicating copy to clipboard operation
frr copied to clipboard

isisd: When operating multiple areas, the system ID behaves abnormally.

Open zhou-run opened this issue 1 year ago • 5 comments

When there are multiple areas on the same router, the following two scenarios exist:

  1. When clearing the net in one of the areas, the system ID is unconditionally cleared, even if the net does not include the current system ID.
  2. When deleting one of the areas, even if the net under the area includes the current system ID, the system ID still remains.

Signed-off-by: zhou-run [email protected]

zhou-run avatar May 27 '24 03:05 zhou-run

How do you test the code before pushing if it's even failing to compile?

ton31337 avatar May 27 '24 08:05 ton31337

How do you test the code before pushing if it's even failing to compile?

Sorry, I have now corrected the compilation error.

zhou-run avatar May 27 '24 12:05 zhou-run

Possible to verify and test this behavior with topotest?

ton31337 avatar May 28 '24 07:05 ton31337

Possible to verify and test this behavior with topotest?

Is topotest necessary? Currently, I have no idea, and it seems that topotest is not available for multi-area. Is multi-area not supported? @ton31337 @riw777

zhou-run avatar Jun 06 '24 02:06 zhou-run

Possible to verify and test this behavior with topotest?

Is topotest necessary? Currently, I have no idea, and it seems that topotest is not available for multi-area. Is multi-area not supported? @ton31337 @riw777

Hmmm... I don't see a multi-area topo test at all ... I'm okay with letting this go without a topo test since it's a bug fix rather than new functionality, but I'll wait on @ton31337 to answer before pushing

riw777 avatar Jun 11 '24 12:06 riw777