frr icon indicating copy to clipboard operation
frr copied to clipboard

Cleanup some OSPF6_LSA_ macros

Open acooks-at-bda opened this issue 1 year ago • 4 comments

This PR proposes the removal of OSPF6_LSA_HEADER_END, OSPF6_LSA_SIZE and OSPF6_LSA_END macros. It replaces those macros with inline functions that enables better type checking and reduces the number of unchecked type casts. No functional change is intended.

acooks-at-bda avatar May 21 '24 07:05 acooks-at-bda

please fix the frrbot style issues and I will get this in.

donaldsharp avatar May 22 '24 13:05 donaldsharp

ci:rerun

ghost avatar May 23 '24 02:05 ghost

ci:rerun

ghost avatar May 23 '24 22:05 ghost

ospf6_ecmp_inter_area.test_ospf6_ecmp_inter_area test_ecmp_inter_area seems to be failing intermittently on the CI. It fails consistently on my dev machine since 217e505

ghost avatar May 24 '24 23:05 ghost