frr icon indicating copy to clipboard operation
frr copied to clipboard

zebra: Update Zebra DPDK >=22.11 API

Open EasyNetDev opened this issue 1 year ago • 3 comments

Hi,

This is my first try to fix Zebra against DPDK >= 22.11 API. Starting from this version DPDK had some changes:

External users may still register their driver using the associated driver headers (see enable_driver_sdk meson option). The rte_driver and rte_device objects are now opaque and must be manipulated through added accessors.

There are few issues still:

  1. To enable the DPDK we need to compile FRRouting with --enable-dp-dpdk=yes
  2. usr/lib/*/frr/modules/zebra_dplane_dpdk.so is missing from debian/frr.install . For testing purpose I've created a script that adds this option and missing lib in the corresponding files.
  3. Zebra is still crashing when I don't have any interfaces attached to DPDK. Keeps #15910 opened until we figured out the issue.

Partial solves #15910 .

EasyNetDev avatar May 13 '24 13:05 EasyNetDev

let's update the commit message to state zebra: Update for DPDK >=22.11 API to follow our standards, also let's remove the merge commit and force push a rebase onto the branch.

donaldsharp avatar May 13 '24 14:05 donaldsharp

let's update the commit message to state zebra: Update for DPDK >=22.11 API to follow our standards, also let's remove the merge commit and force push a rebase onto the branch.

Thanks for suggestion. Is ok now? I will check the Zebra DPDK files for correct clang-format and I will push another PR for formatting.

EasyNetDev avatar May 13 '24 14:05 EasyNetDev

Please fix the problems identified by frrbot.

donaldsharp avatar May 14 '24 13:05 donaldsharp

Please fix the problems identified by frrbot.

This is very weird. I tested with git clang-format and give me no changes. I applied what frrbot suggested.

EasyNetDev avatar May 16 '24 11:05 EasyNetDev