tests: exception handling at ospf testcases

[y-bharath14]

exception handling at ospf and ospf6 testcases

[ton31337]

What does it solve here, and why only ospfX?

[y-bharath14]

What does it solve here, and why only ospfX?

Hi Donatas Abraitis,

Thanks for the review !!

During the session cleanup, I mean at stop_topology(), there are cases where mininet tries to stop the switch eventhough switch is stopped at once. When mininet tries to stop the same switch again and again, it ended with the exception. So, we are handling this as part of OSError.

Initially , I have started with ospfX module. Going forward, I will do the same change across all the modules. For ospfX module alone, I could see change is needed in 46 files. If I do change in all modules, file count will be more.

So, I felt doing module by module changes would be a wise option.

Thanks & Regards, Bharath

[ton31337]

But... maybe this should be handled globally inside the libs (stop_topology()), and not per-test?

[y-bharath14]

Hi Donatas Abraitis,

Hi Donatas Abraitis,

Addressed review comment. Thank you.

Regards, Bharath

[y-bharath14]

Squash two commits into a single one (they are a single change here).

Hi Donatas Abraitis,

Squashed two commits into a single one. Thank you.

Regards, Bharath

[riw777]

looks relevant

      Error: [DUT: FRR] OSPF GR Helper: activeRestarterCnt
   assert '[DUT: FRR] OSPF GR Helper: activeRestarterCnt' is True```

[riw777]

@ton31337 ping ... :-)

[riw777]

ci started 27 days ago ... seems hung?

ci:rerun

[y-bharath14]

ci started 27 days ago ... seems hung?

ci:rerun

@riw777, I did rebase of branch. Now CI results seems to be fine.

Thanks, Bharath