frr
frr copied to clipboard
tools: Add option to frr-reload to specify alternate logfile
Adding option --logfile to specify a different logfile instead of the default /var/log/frr/frr-reload.log
This solves the issue with multiple FRR instances running in different network namespaces to use different logfiles
Signed-off-by: Martin Winter [email protected]
ci:retry
This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.
@mwinter-osr Did we still want to get this in? Also as a further improvement should the path for the default log file use some value from ./configure?
This pull request has conflicts, please resolve those before we can evaluate the pull request.
@mwinter-osr Did we still want to get this in? Also as a further improvement should the path for the default log file use some value from
./configure?
Somehow completely dropped the ball on this and just re-discovered it again. The PR is now rebased, but in relation to your comments: I don't think it make sense to have this based from configure: The main motivation was for users which run multiple FRR in different namespaces. They wouldn't build different versions.
If you think otherwise, then please explain how or why. (I think giving options for everything just to have options might not be useful. Or are you asking about a feature to specifiy a different logdir? If yes, then that should be in a different PR as it's not directly related.