frr icon indicating copy to clipboard operation
frr copied to clipboard

Published 20 hours ago • verified publisher icon FRRouting

*: Remove int return for zapi functions

Open donaldsharp opened this issue 1 year ago • 7 comments

The code never uses the return code for Zapi functions. Let's remove it.

donaldsharp avatar Jan 24 '24 23:01 donaldsharp

ci:rerun CI failed to trigger github check API or so, it's green, but missed a hook

ton31337 avatar Jan 25 '24 09:01 ton31337

ci:rerun

donaldsharp avatar Jan 25 '24 12:01 donaldsharp

Hmm - but ... I've thought (sometimes) that getting feedback from zapi apis might be one of the ways we'd be able to do a better job of avoiding buffering when sending to zebra. I'd rather leave that possibility open?

mjstapp avatar Jan 25 '24 12:01 mjstapp

This is reception of data from zebra, not sending of data to zebra.

donaldsharp avatar Jan 25 '24 12:01 donaldsharp

looks like there are build failures ... :-(

riw777 avatar Feb 13 '24 14:02 riw777

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 03 '24 06:04 github-actions[bot]