frr icon indicating copy to clipboard operation
frr copied to clipboard

srv6: Introduce binding-sid end.b6.encaps used by TE policy.

Open dmytroshytyi-6WIND opened this issue 1 year ago • 15 comments

These series of patches introduce new feature: user may configure TE policy srv6 binding SID End.B6.Encaps [0].

Specify the TE policy SRv6 Binding SID:

clicmd:: srv6-binding-sid X:X::X:X

Configuration example:

        configure
         segment-routing
         traffic-eng
          segment-list srv6-header
           index 1 ipv6-address fc00:0:4::
           index 2 ipv6-address fc00:0:5::
          exit
          policy color 1 endpoint fc00:0:6::
           srv6-binding-sid fc00:0:2::                    <<<                    SRv6 binding SID End.B6.Encaps          
           candidate-path preference 1 name srv6 explicit segment-list srv6-header
         exit
        exit
        !

[0] https://www.ietf.org/rfc/rfc8986.html#name-endb6encaps-endpoint-bound-

dmytroshytyi-6WIND avatar Jan 18 '24 13:01 dmytroshytyi-6WIND

ci:rerun

dmytroshytyi-6WIND avatar Jan 23 '24 16:01 dmytroshytyi-6WIND

ci:rerun

dmytroshytyi-6WIND avatar Jan 23 '24 22:01 dmytroshytyi-6WIND

ci:rerun

dmytroshytyi-6WIND avatar Jan 24 '24 03:01 dmytroshytyi-6WIND

ci:rerun

dmytroshytyi-6WIND avatar Jan 24 '24 07:01 dmytroshytyi-6WIND

ci:rerun

dmytroshytyi-6WIND avatar Jan 25 '24 15:01 dmytroshytyi-6WIND

Hi Dmytro, Thanks for making these changes and the PR.

I have some High-Level comments.

In the following CLI: configure segment-routing traffic-eng segment-list srv6-header index 1 ipv6-address fc00:0:4::

The fc00:0:4:: is an SRv6 SID value and NOT an IPv6 address (by looking at your ISIS configuration). Can you please make the following change? s /index ipv6-address <S>/ index srv6 SID <S> The use of "srv6 SID" will align the CLI with the MPLS counterpart (mpls label <L>).

For "srv6-binding-sid fc00:0:2::" CLI, the cross-pounding MPLS counterpart is "binding-sid 1111: You may like to consider "binding-sid srv6 <S>."

Did you test SRv6 uSID encapsulation of the SIDs in the sid-list?

Thanks

ZAFARALI95 avatar Feb 12 '24 22:02 ZAFARALI95

Hello, Thank you for interest in this PR.

The fc00:0:4:: is an SRv6 SID value and NOT an IPv6 address (by looking at your ISIS configuration). Can you please make the following change? s /index ipv6-address / index srv6 SID The use of "srv6 SID" will align the CLI with the MPLS counterpart (mpls label ).

Are you aware of this RFC8402 ? The section 2 "Terminology" states the next: "SRv6 SID: an IPv6 address..."

Best, Dmytro.

dmytroshytyi-6WIND avatar Feb 22 '24 14:02 dmytroshytyi-6WIND

ci:restart

dmytroshytyi-6WIND avatar Apr 02 '24 08:04 dmytroshytyi-6WIND

ci:rerun

pguibert6WIND avatar Apr 03 '24 08:04 pguibert6WIND

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 05 '24 17:04 github-actions[bot]

ci:rerun

dmytroshytyi-6WIND avatar May 02 '24 14:05 dmytroshytyi-6WIND

ci:rerun 1 unrelated failure

dmytroshytyi-6WIND avatar May 03 '24 22:05 dmytroshytyi-6WIND

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 18 '24 16:06 github-actions[bot]