frr icon indicating copy to clipboard operation
frr copied to clipboard

vtysh "lsp-gen-interval 2" not setting isis area->lsp_gen_interval

Open ksschoener opened this issue 2 years ago • 4 comments
trafficstars

While running FRR release: 8.4.2, configuring ISIS with lsp-timers is not setting the isis area->lsp_gen_interval.

Specifically, test is configuring FRR ISIS with: lsp-timers gen-interval 2 refresh-interval 900 max-lifetime 1200

When ISIS adjacency establishes, the following ISIS log is observed: 2023/10/11 16:30:59 ISIS: [TTN2A-W5V2A] ISIS (d1a1605a17c4): Scheduling in 30000 ms to match configured lsp_gen_interval

Also, ran topotest isis_topo1. This topotest contains isis configuration: lsp-gen-interval 2

Locally, I added debug logs that confirmed: when running isis_topo1, isis_area_create is setting lsp_gen_interval to 30 on this line: https://github.com/FRRouting/frr/blob/master/isisd/isisd.c#L357

Ran isis_topo1 with FRR at the following commit hash:

$ git log
commit b9668023622328468a30fe530bab86afdc914878 (HEAD -> master, origin/master, origin/HEAD)
Merge: 4a6004568 a09cb688a
Author: Donald Sharp <[email protected]>
Date:   Mon Oct 9 10:36:00 2023 -0400

    Merge pull request #14543 from mjstapp/fix_pbr_rule_unique

    zebra: add zclient to iprules key

ksschoener avatar Oct 11 '23 18:10 ksschoener

What debug command did you have configured to see the log message? Just ran a test on 8.5.2 with the following configs and did not see the same log message:

router isis ABC
 lsp-timers gen-interval 1 refresh-interval 300 max-lifetime 1000
!
debug isis adj-packets
debug isis spf-events
debug isis lsp-gen
debug isis lsp-sched

beith12 avatar Nov 01 '23 13:11 beith12

I added that log message as a local patch to my sandbox.

Locally, I added debug logs that confirmed: when running isis_topo1, isis_area_create is setting lsp_gen_interval to 30 on this line: https://github.com/FRRouting/frr/blob/master/isisd/isisd.c#L357

ksschoener avatar Nov 30 '23 16:11 ksschoener

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

github-actions[bot] avatar May 29 '24 01:05 github-actions[bot]

This issue will be automatically closed in the specified period unless there is further activity.

frrbot[bot] avatar May 29 '24 01:05 frrbot[bot]