frr
frr copied to clipboard
FRRouting
zebra: fix help handler for 'mpls label global-block'
The help handler refers to segment routing. Fix it.
Fixes: 1b6d5c7e0873 ("bgpd, zebra: Implement BGP Prefix-SID IETF draft")
Is this really for segment routing?
BGP segment routing.
Don't you use this command to create a label pool for IS-IS, though?
Is this really for segment routing?
BGP segment routing.
Don't you use this command to create a label pool for IS-IS, though?
actually, no. This command is specific to BGP segment routing MPLS.
As I read the code, the global label block is a generic bit of code that can be used by anyone using FEC's. Which is more than just BGP right? What is the problem that you are trying to solve? How would this help people attempting to use this command for say ldpd?
I just wanted to clarify what that label block was for.
which is more than just BGP right? You are right. I would say, actually, more than just BGP prefix SID cases. (as with LDP, I don't see the use case).
How would this help people attempting to use this command for say ldpd? I need to think of a rework of this pull request to :
- either add a description that covers all FEC use cases
- or limit the usage of the global block to FEC with prefix-SID.