Continuation of https://github.com/FRRouting/frr/pull/12631/

in order to solve:

crashes with soft-reconfiguration inbound after a prefix is re-accepted after a route-map change label vpn export value change

Jun 08 '23 16:06 louis-6wind

Why not continue on https://github.com/FRRouting/frr/pull/12631? Now we have two PRs for the same with different histories of comments, suggestions, etc.

Jun 08 '23 17:06 ton31337

Why not continue on #12631? Now we have two PRs for the same with different histories of comments, suggestions, etc.

this is a draft version.

Jun 08 '23 17:06 pguibert6WIND

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Addresssanitizer topotests part 4: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `r3`

    ERROR: AddressSanitizer: SEGV on unknown address 0x0000000018a6 (pc 0x7f8f4c1903a6 bp 0x0000000003fd sp 0x7ffdc3afa7c0 T0)
        #0 0x7f8f4c1903a5  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5)
        #1 0x7f8f4c191443  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2b443)
        #2 0x7f8f4c244772 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde772)
        #3 0x565339bcafdf in qfree lib/memory.c:130
        #4 0x565339a9df81 in zebra_nhg_free zebra/zebra_nhg.c:1636
        #5 0x565339a77ff5 in mpls_ftn_uninstall_all zebra/zebra_mpls.c:3484
        #6 0x565339a78c3a in zebra_mpls_cleanup_zclient_labels zebra/zebra_mpls.c:2526
        #7 0x565339b38459 in hook_call_zserv_client_close zebra/zserv.c:561
        #8 0x565339b38459 in zserv_client_free zebra/zserv.c:580
        #9 0x565339b38459 in zserv_close_client zebra/zserv.c:701
        #10 0x5653399dd8e0 in sigint zebra/main.c:156
        #11 0x565339c3aa44 in frr_sigevent_process lib/sigevent.c:115
        #12 0x565339c656ff in event_fetch lib/event.c:1761
        #13 0x565339bad882 in frr_run lib/libfrr.c:1212
        #14 0x5653399de1b4 in main zebra/main.c:467
        #15 0x7f8f4aaa0c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #16 0x5653399aab09 in _start (/usr/lib/frr/zebra+0x2f7b09)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5) 

---------------
## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `ce1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x00000000198f (pc 0x7f4e065623a6 bp 0x0000000002c4 sp 0x7ffe2b24ee70 T0)
        #0 0x7f4e065623a5  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5)
        #1 0x7f4e06563443  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2b443)
        #2 0x7f4e06616772 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde772)
        #3 0x55bf8b9affdf in qfree lib/memory.c:130
        #4 0x55bf8b882f81 in zebra_nhg_free zebra/zebra_nhg.c:1636
        #5 0x55bf8b85cff5 in mpls_ftn_uninstall_all zebra/zebra_mpls.c:3484
        #6 0x55bf8b85dc3a in zebra_mpls_cleanup_zclient_labels zebra/zebra_mpls.c:2526
        #7 0x55bf8b91d459 in hook_call_zserv_client_close zebra/zserv.c:561
        #8 0x55bf8b91d459 in zserv_client_free zebra/zserv.c:580
        #9 0x55bf8b91d459 in zserv_close_client zebra/zserv.c:701
        #10 0x55bf8b7c28e0 in sigint zebra/main.c:156
        #11 0x55bf8ba1fa44 in frr_sigevent_process lib/sigevent.c:115
        #12 0x55bf8ba4a6ff in event_fetch lib/event.c:1761
        #13 0x55bf8b992882 in frr_run lib/libfrr.c:1212
        #14 0x55bf8b7c31b4 in main zebra/main.c:467
        #15 0x7f4e04e72c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #16 0x55bf8b78fb09 in _start (/usr/lib/frr/zebra+0x2f7b09)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5) 

---------------
## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `ce2`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000001a33 (pc 0x7f787b2b35f0 bp 0x6190006a2c80 sp 0x7ffe55e8e358 T0)
        #0 0x7f787b2b35ef  (/lib/x86_64-linux-gnu/libc.so.6+0xbb5ef)
        #1 0x7f787c906080  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x27080)
        #2 0x7f787c9bdcf0 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdecf0)
        #3 0x55e852ab164b in qcalloc lib/memory.c:105
        #4 0x55e85291959a in dplane_ctx_alloc zebra/zebra_dplane.c:651
        #5 0x55e8529232e3 in dplane_route_update_internal zebra/zebra_dplane.c:3676
        #6 0x55e852923b11 in dplane_route_delete zebra/zebra_dplane.c:3992
        #7 0x55e85299f266 in rib_uninstall_kernel zebra/zebra_rib.c:741
        #8 0x55e8529adf7b in rib_close_table zebra/zebra_rib.c:4668
        #9 0x55e8529c6f8b in zebra_vrf_disable zebra/zebra_vrf.c:192
        #10 0x55e852b55e7d in vrf_disable lib/vrf.c:325
        #11 0x55e852b56380 in vrf_terminate_single lib/vrf.c:512
        #12 0x55e852b56bc3 in vrf_terminate lib/vrf.c:543
        #13 0x55e8528c4ac2 in zebra_finalize zebra/main.c:207
        #14 0x55e852b4eb08 in event_call lib/event.c:1995
        #15 0x55e852a94877 in frr_run lib/libfrr.c:1213
        #16 0x55e8528c51b4 in main zebra/main.c:467
        #17 0x7f787b219c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #18 0x55e852891b09 in _start (/usr/lib/frr/zebra+0x2f7b09)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0xbb5ef) 

---------------

Addresssanitizer topotests part 4: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/ASANP4/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASANP4-12142/test

Topology Tests failed for Addresssanitizer topotests part 4 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/ASANP4/Topotest-Logs/log_topotests.txt

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12142/test

Topology Tests failed for Topotests debian 10 amd64 part 9 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 9: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-12142/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 6: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO6U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-12142/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO6DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 6: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO6DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-12142/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO6U18AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 6: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12142/artifact/TOPO6U18AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Debian 10 deb pkg check
Addresssanitizer topotests part 3
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 1
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 5
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings

Addresssanitizer topotests part 4: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `r3`

    ERROR: AddressSanitizer: SEGV on unknown address 0x0000000018a6 (pc 0x7f8f4c1903a6 bp 0x0000000003fd sp 0x7ffdc3afa7c0 T0)
        #0 0x7f8f4c1903a5  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5)
        #1 0x7f8f4c191443  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2b443)
        #2 0x7f8f4c244772 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde772)
        #3 0x565339bcafdf in qfree lib/memory.c:130
        #4 0x565339a9df81 in zebra_nhg_free zebra/zebra_nhg.c:1636
        #5 0x565339a77ff5 in mpls_ftn_uninstall_all zebra/zebra_mpls.c:3484
        #6 0x565339a78c3a in zebra_mpls_cleanup_zclient_labels zebra/zebra_mpls.c:2526
        #7 0x565339b38459 in hook_call_zserv_client_close zebra/zserv.c:561
        #8 0x565339b38459 in zserv_client_free zebra/zserv.c:580
        #9 0x565339b38459 in zserv_close_client zebra/zserv.c:701
        #10 0x5653399dd8e0 in sigint zebra/main.c:156
        #11 0x565339c3aa44 in frr_sigevent_process lib/sigevent.c:115
        #12 0x565339c656ff in event_fetch lib/event.c:1761
        #13 0x565339bad882 in frr_run lib/libfrr.c:1212
        #14 0x5653399de1b4 in main zebra/main.c:467
        #15 0x7f8f4aaa0c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #16 0x5653399aab09 in _start (/usr/lib/frr/zebra+0x2f7b09)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5) 

---------------
## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `ce1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x00000000198f (pc 0x7f4e065623a6 bp 0x0000000002c4 sp 0x7ffe2b24ee70 T0)
        #0 0x7f4e065623a5  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5)
        #1 0x7f4e06563443  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2b443)
        #2 0x7f4e06616772 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde772)
        #3 0x55bf8b9affdf in qfree lib/memory.c:130
        #4 0x55bf8b882f81 in zebra_nhg_free zebra/zebra_nhg.c:1636
        #5 0x55bf8b85cff5 in mpls_ftn_uninstall_all zebra/zebra_mpls.c:3484
        #6 0x55bf8b85dc3a in zebra_mpls_cleanup_zclient_labels zebra/zebra_mpls.c:2526
        #7 0x55bf8b91d459 in hook_call_zserv_client_close zebra/zserv.c:561
        #8 0x55bf8b91d459 in zserv_client_free zebra/zserv.c:580
        #9 0x55bf8b91d459 in zserv_close_client zebra/zserv.c:701
        #10 0x55bf8b7c28e0 in sigint zebra/main.c:156
        #11 0x55bf8ba1fa44 in frr_sigevent_process lib/sigevent.c:115
        #12 0x55bf8ba4a6ff in event_fetch lib/event.c:1761
        #13 0x55bf8b992882 in frr_run lib/libfrr.c:1212
        #14 0x55bf8b7c31b4 in main zebra/main.c:467
        #15 0x7f4e04e72c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #16 0x55bf8b78fb09 in _start (/usr/lib/frr/zebra+0x2f7b09)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5) 

---------------
## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `ce2`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000001a33 (pc 0x7f787b2b35f0 bp 0x6190006a2c80 sp 0x7ffe55e8e358 T0)
        #0 0x7f787b2b35ef  (/lib/x86_64-linux-gnu/libc.so.6+0xbb5ef)
        #1 0x7f787c906080  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x27080)
        #2 0x7f787c9bdcf0 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdecf0)
        #3 0x55e852ab164b in qcalloc lib/memory.c:105
        #4 0x55e85291959a in dplane_ctx_alloc zebra/zebra_dplane.c:651
        #5 0x55e8529232e3 in dplane_route_update_internal zebra/zebra_dplane.c:3676
        #6 0x55e852923b11 in dplane_route_delete zebra/zebra_dplane.c:3992
        #7 0x55e85299f266 in rib_uninstall_kernel zebra/zebra_rib.c:741
        #8 0x55e8529adf7b in rib_close_table zebra/zebra_rib.c:4668
        #9 0x55e8529c6f8b in zebra_vrf_disable zebra/zebra_vrf.c:192
        #10 0x55e852b55e7d in vrf_disable lib/vrf.c:325
        #11 0x55e852b56380 in vrf_terminate_single lib/vrf.c:512
        #12 0x55e852b56bc3 in vrf_terminate lib/vrf.c:543
        #13 0x55e8528c4ac2 in zebra_finalize zebra/main.c:207
        #14 0x55e852b4eb08 in event_call lib/event.c:1995
        #15 0x55e852a94877 in frr_run lib/libfrr.c:1213
        #16 0x55e8528c51b4 in main zebra/main.c:467
        #17 0x7f787b219c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #18 0x55e852891b09 in _start (/usr/lib/frr/zebra+0x2f7b09)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0xbb5ef) 

---------------