vtysh: `service wrap-config`

[eqvinox]

trafficstars

As noted in commit text:

This allows invoking an external wrapper script with config on stdin/out and frr.conf on stdout/in for saving/loading respectively.

Example use cases would be doing a "git commit" on /etc/frr each time the config is saved, pushing the config into some database for backup or history purposes, or interfacing with system security infrastructure (e.g. TPM to keep keys).

---

TODO (hence draft):

• improve wrapper script interfacing (some env variables with config path & namespace)
• adjust frr-reload.py so it can use the same wrapper script
• documentation
• some basic test
• double check that forked config load on startup works correctly
• cleanup, style fixes, inevitable CI breakage

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12037/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12037/test

Topology Tests failed for Topotests debian 10 amd64 part 9 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12037/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 9: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12037/artifact/TOPO9DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

• Topotests debian 10 amd64 part 8
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 9
• Ubuntu 18.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Debian 10 deb pkg check
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 amd64 part 9
• Addresssanitizer topotests part 4
• Debian 9 deb pkg check
• Topotests Ubuntu 18.04 i386 part 8
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 i386 part 3
• Topotests debian 10 amd64 part 4
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 i386 part 9
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests debian 10 amd64 part 1
• Static analyzer (clang)
• Addresssanitizer topotests part 5
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 i386 part 1
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 6
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests debian 10 amd64 part 0
• Addresssanitizer topotests part 9
• Topotests debian 10 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 7
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 amd64 part 3
• Addresssanitizer topotests part 6
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 i386 part 0
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 amd64 part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12037/test

Topology Tests failed for Topotests debian 10 amd64 part 9 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12037/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 9: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12037/artifact/TOPO9DEB10AMD64/TopotestDetails/

Report for vtysh_main.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #511: FILE: /tmp/f1-3378484/vtysh_main.c:511:

[github-actions[bot]]

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.