frr
frr copied to clipboard
zebra: add basic traffic control API
This PR is supposed to add traffic control netlink APIs, contexts, and its main handling parts to zebra.
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6685/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Failed
Checkout code: Failed (click for details)
PullReq merge failed. Please rebase your branch: see merge log in attachment https://ci1.netdef.org/browse/FRR-PULLREQ2-6685/artifact/CHECKOUT/ErrorLog/log_merge.txt
Outdated results 🛑
Basic BGPD CI results: FAILURE
_ | _ |
---|---|
Result | FAILURE git merge/11694 9999fa183 frr.github Build |
Date | 07/29/2022 |
Start | 10:01:29 |
Finish | 10:02:05 |
Run-Time | 00:36 |
Total | |
Pass | |
Fail | |
Valgrind-Errors | |
Valgrind-Loss | |
Details | vncregress-2022-07-29-10:01:29.txt |
Log | make-2022-07-29-10:01:29.out.bz2 |
Memory |
For details, please contact louberger
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
OpenBSD 7 amd64 build: Failed (click for details)
Make failed for OpenBSD 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI011BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: 'linux/if_ether.h' file not found
#include <linux/if_ether.h>
1 error generated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.6726/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI011BUILD/config.status/config.status OpenBSD 7 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI011BUILD/config.log/config.log.gz
Redhat 8 amd64 build: Failed (click for details)
Redhat 8 amd64 build: Unknown LogMake failed for Redhat 8 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/REDHAT8/ErrorLog/log_make.txt)
^~~~~~~~~~
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/REDHAT8/config.status/config.status
Debian 10 amd64 build: Failed (click for details)
Debian 10 amd64 build: Unknown LogMake failed for Debian 10 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB10BUILD/ErrorLog/log_make.txt)
^~~~~~~~~~
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB10BUILD/config.status/config.status
Fedora 29 amd64 build: Failed (click for details)
Make failed for Fedora 29 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/F29BUILD/ErrorLog/log_make.txt)
^~~~~~~~~~
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/F29BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: Failed (click for details)
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown LogMake failed for Ubuntu 16.04 arm7 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI101BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 20.04 amd64 build: Failed (click for details)
Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U2004AMD64BUILD/config.status/config.statusMake failed for Ubuntu 20.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U2004AMD64BUILD/config.log/config.log.gz
FreeBSD 11 amd64 build: Failed (click for details)
Make failed for FreeBSD 11 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI009BUILD/ErrorLog/log_make.txt)
/usr/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/usr/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6726/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI009BUILD/config.status/config.status FreeBSD 11 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI009BUILD/config.log/config.log.gz
Ubuntu 22.04 amd64 build: Failed (click for details)
Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U22AMD64BUILD/config.status/config.statusMake failed for Ubuntu 22.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:17: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:17: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:34: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
zebra/debug_nl.c:1737:17: note: in expansion of macro zlog_debug
Ubuntu 22.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U22AMD64BUILD/config.log/config.log.gz
CentOS 7 amd64 build: Failed (click for details)
Make failed for CentOS 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI005BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory `/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/assert/assert.h:31:0,
./lib/xref.h:254:22: warning: format %s expects a matching char * argument [-Wformat=]
./lib/zlog.h:119:3: note: in expansion of macro XREF_LINK
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI005BUILD/config.log/config.log.gz
Debian 9 amd64 build: Failed (click for details)
Make failed for Debian 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI021BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI021BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: Failed (click for details)
Make failed for Ubuntu 16.04 arm8 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U16ARM8BUILD/config.status/config.status
Redhat 9 amd64 build: Failed (click for details)
Redhat 9 amd64 build: Unknown LogMake failed for Redhat 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/RH9BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:17: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:17: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:34: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
zebra/debug_nl.c:1737:17: note: in expansion of macro zlog_debug
Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/RH9BUILD/config.status/config.status
Ubuntu 18.04 amd64 build: Failed (click for details)
Make failed for Ubuntu 18.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804AMD64/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804AMD64/config.log/config.log.gz
Ubuntu 18.04 ppc64le build: Failed (click for details)
Make failed for Ubuntu 18.04 ppc64le build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804PPC64LEBUILD/config.log/config.log.gz
NetBSD 9 amd64 build: Failed (click for details)
NetBSD 9 amd64 build: Unknown LogMake failed for NetBSD 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI012BUILD/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10363: zebra/tc_netlink.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:16968: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI012BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Failed (click for details)
Make failed for Ubuntu 16.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI014BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI014BUILD/config.log/config.log.gz
FreeBSD 12 amd64 build: Failed (click for details)
Make failed for FreeBSD 12 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/FBSD12AMD64/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10359: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6726/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6372: all] Error 2
FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/FBSD12AMD64/config.status/config.status FreeBSD 12 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/FBSD12AMD64/config.log/config.log.gz
Ubuntu 18.04 i386 build: Failed (click for details)
Ubuntu 18.04 i386 build: Unknown LogMake failed for Ubuntu 18.04 i386 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18I386BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 arm7 build: Failed (click for details)
Make failed for Ubuntu 18.04 arm7 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM7BUILD/config.status/config.status
Ubuntu 18.04 arm8 build: Failed (click for details)
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown LogMake failed for Ubuntu 18.04 arm8 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 16.04 i386 build: Failed (click for details)
Make failed for Ubuntu 16.04 i386 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1604I386/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1604I386/config.log/config.log.gz
Debian 11 amd64 build: Failed (click for details)
Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB11AMD64/config.status/config.statusMake failed for Debian 11 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB11AMD64/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
zebra/debug_nl.c:1742:3: error: tccm undeclared (first use in this function)
1742 | tccm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1748:3: error: tcfm undeclared (first use in this function)
1748 | tcfm = NLMSG_DATA(nlmsg);
Debian 11 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB11AMD64/config.log/config.log.gz
Warnings Generated during build:
Checkout code: Successful with additional warnings
OpenBSD 7 amd64 build: Failed (click for details)
Make failed for OpenBSD 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI011BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: 'linux/if_ether.h' file not found
#include <linux/if_ether.h>
1 error generated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.6726/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI011BUILD/config.status/config.status OpenBSD 7 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI011BUILD/config.log/config.log.gz
Redhat 8 amd64 build: Failed (click for details)
Redhat 8 amd64 build: Unknown LogMake failed for Redhat 8 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/REDHAT8/ErrorLog/log_make.txt)
^~~~~~~~~~
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/REDHAT8/config.status/config.status
Debian 10 amd64 build: Failed (click for details)
Debian 10 amd64 build: Unknown LogMake failed for Debian 10 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB10BUILD/ErrorLog/log_make.txt)
^~~~~~~~~~
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB10BUILD/config.status/config.status
Fedora 29 amd64 build: Failed (click for details)
Make failed for Fedora 29 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/F29BUILD/ErrorLog/log_make.txt)
^~~~~~~~~~
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/F29BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: Failed (click for details)
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown LogMake failed for Ubuntu 16.04 arm7 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI101BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 20.04 amd64 build: Failed (click for details)
Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U2004AMD64BUILD/config.status/config.statusMake failed for Ubuntu 20.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U2004AMD64BUILD/config.log/config.log.gz
FreeBSD 11 amd64 build: Failed (click for details)
Make failed for FreeBSD 11 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI009BUILD/ErrorLog/log_make.txt)
/usr/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/usr/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6726/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI009BUILD/config.status/config.status FreeBSD 11 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI009BUILD/config.log/config.log.gz
Ubuntu 22.04 amd64 build: Failed (click for details)
Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U22AMD64BUILD/config.status/config.statusMake failed for Ubuntu 22.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:17: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:17: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:34: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
zebra/debug_nl.c:1737:17: note: in expansion of macro zlog_debug
Ubuntu 22.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U22AMD64BUILD/config.log/config.log.gz
CentOS 7 amd64 build: Failed (click for details)
Make failed for CentOS 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI005BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory `/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/assert/assert.h:31:0,
./lib/xref.h:254:22: warning: format %s expects a matching char * argument [-Wformat=]
./lib/zlog.h:119:3: note: in expansion of macro XREF_LINK
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI005BUILD/config.log/config.log.gz
Debian 9 amd64 build: Failed (click for details)
Make failed for Debian 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI021BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI021BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: Failed (click for details)
Make failed for Ubuntu 16.04 arm8 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U16ARM8BUILD/config.status/config.status
Redhat 9 amd64 build: Failed (click for details)
Redhat 9 amd64 build: Unknown LogMake failed for Redhat 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/RH9BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:17: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:17: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32,
./lib/zlog.h:120:34: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
zebra/debug_nl.c:1737:17: note: in expansion of macro zlog_debug
Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/RH9BUILD/config.status/config.status
Ubuntu 18.04 amd64 build: Failed (click for details)
Make failed for Ubuntu 18.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804AMD64/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804AMD64/config.log/config.log.gz
Ubuntu 18.04 ppc64le build: Failed (click for details)
Make failed for Ubuntu 18.04 ppc64le build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1804PPC64LEBUILD/config.log/config.log.gz
NetBSD 9 amd64 build: Failed (click for details)
NetBSD 9 amd64 build: Unknown LogMake failed for NetBSD 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI012BUILD/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10363: zebra/tc_netlink.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:16968: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI012BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Failed (click for details)
Make failed for Ubuntu 16.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI014BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/CI014BUILD/config.log/config.log.gz
FreeBSD 12 amd64 build: Failed (click for details)
Make failed for FreeBSD 12 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/FBSD12AMD64/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10359: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6726/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6372: all] Error 2
FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/FBSD12AMD64/config.status/config.status FreeBSD 12 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/FBSD12AMD64/config.log/config.log.gz
Ubuntu 18.04 i386 build: Failed (click for details)
Ubuntu 18.04 i386 build: Unknown LogMake failed for Ubuntu 18.04 i386 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18I386BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 arm7 build: Failed (click for details)
Make failed for Ubuntu 18.04 arm7 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM7BUILD/config.status/config.status
Ubuntu 18.04 arm8 build: Failed (click for details)
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown LogMake failed for Ubuntu 18.04 arm8 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function); did you mean tnlm?
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
In file included from ./lib/log.h:32:0,
./lib/zlog.h:120:20: error: format %s expects a matching char * argument [-Werror=format=]
./lib/zlog.h:127:26: note: in expansion of macro _zlog_ecref
#define zlog_debug(...) _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
zebra/debug_nl.c:1737:3: note: in expansion of macro zlog_debug
Ubuntu 16.04 i386 build: Failed (click for details)
Make failed for Ubuntu 16.04 i386 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1604I386/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6726/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/U1604I386/config.log/config.log.gz
Debian 11 amd64 build: Failed (click for details)
Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB11AMD64/config.status/config.statusMake failed for Debian 11 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB11AMD64/ErrorLog/log_make.txt)
/home/ci/cibuild.6726/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/debug_nl.c: In function nl_dump:
zebra/debug_nl.c:1736:3: error: tcqm undeclared (first use in this function)
1736 | tcqm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1736:3: note: each undeclared identifier is reported only once for each function it appears in
zebra/debug_nl.c:1742:3: error: tccm undeclared (first use in this function)
1742 | tccm = NLMSG_DATA(nlmsg);
zebra/debug_nl.c:1748:3: error: tcfm undeclared (first use in this function)
1748 | tcfm = NLMSG_DATA(nlmsg);
Debian 11 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6726/artifact/DEB11AMD64/config.log/config.log.gz
<stdin>:57: space before tab in indent.
break; /* should never hit here */
warning: 1 line adds whitespace errors.
Report for debug_nl.c | 2 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #1733: FILE: /tmp/f1-15146/debug_nl.c:1733:
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-15146/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-15146/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-15146/interface.c:1582:
Report for tc_netlink.c | 59 issues
===============================================
WARNING: C99 // comments do not match recommendation
#50: FILE: /tmp/f1-15146/tc_netlink.c:50:
+// TODO: move these bitflags to zebra_tc.h
WARNING: braces {} are not necessary for single statement blocks
#80: FILE: /tmp/f1-15146/tc_netlink.c:80:
+ if (freq) {
+ return freq;
+ }
WARNING: braces {} are not necessary for single statement blocks
#114: FILE: /tmp/f1-15146/tc_netlink.c:114:
+ for (int i = 0; i < 256; i++) {
+ table[i] = xmittime(ratespec->rate, (i + 1) << cell_log);
+ }
WARNING: Missing a blank line after declarations
#228: FILE: /tmp/f1-15146/tc_netlink.c:228:
+ const char *kind = "htb";
+ nl_attr_put(&req->n, datalen, TCA_KIND, kind, strlen(kind) + 1);
WARNING: Missing a blank line after declarations
#230: FILE: /tmp/f1-15146/tc_netlink.c:230:
+ struct rtattr *nest = nl_attr_nest(&req->n, datalen, TCA_OPTIONS);
+ nl_attr_put(&req->n, datalen, TCA_HTB_INIT, &htb_glob,
WARNING: braces {} are not necessary for single statement blocks
#275: FILE: /tmp/f1-15146/tc_netlink.c:275:
+ if (ceil < rate) {
+ ceil = rate;
+ }
WARNING: C99 // comments do not match recommendation
#282: FILE: /tmp/f1-15146/tc_netlink.c:282:
+ // TODO: fetch mtu from interface
WARNING: C99 // comments do not match recommendation
#353: FILE: /tmp/f1-15146/tc_netlink.c:353:
+ // TODO: priority support
WARNING: Missing a blank line after declarations
#357: FILE: /tmp/f1-15146/tc_netlink.c:357:
+ uint16_t protocol = htons(ETH_P_IP);
+ req->t.tcm_info = tc_make_handle(priority, protocol);
WARNING: Missing a blank line after declarations
#360: FILE: /tmp/f1-15146/tc_netlink.c:360:
+ uint32_t classid = tc_get_handle(ctx, 1);
+ req->t.tcm_handle = 1;
WARNING: Missing a blank line after declarations
#415: FILE: /tmp/f1-15146/tc_netlink.c:415:
+ uint32_t flags = 0;
+ nl_attr_put32(&req->n, datalen, TCA_FLOWER_FLAGS, flags);
WARNING: C99 // comments do not match recommendation
#444: FILE: /tmp/f1-15146/tc_netlink.c:444:
+ // TODO: error handling and other actions (delete, replace, ...)
Report for zebra_dplane.c | 40 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #324: FILE: /tmp/f1-15146/zebra_dplane.c:324:
< WARNING: C99 // comments do not match recommendation
< #325: FILE: /tmp/f1-15146/zebra_dplane.c:325:
< WARNING: C99 // comments do not match recommendation
< #326: FILE: /tmp/f1-15146/zebra_dplane.c:326:
< WARNING: C99 // comments do not match recommendation
< #334: FILE: /tmp/f1-15146/zebra_dplane.c:334:
< WARNING: C99 // comments do not match recommendation
< #336: FILE: /tmp/f1-15146/zebra_dplane.c:336:
< WARNING: C99 // comments do not match recommendation
< #337: FILE: /tmp/f1-15146/zebra_dplane.c:337:
< WARNING: C99 // comments do not match recommendation
< #340: FILE: /tmp/f1-15146/zebra_dplane.c:340:
< WARNING: C99 // comments do not match recommendation
< #341: FILE: /tmp/f1-15146/zebra_dplane.c:341:
< WARNING: C99 // comments do not match recommendation
< #343: FILE: /tmp/f1-15146/zebra_dplane.c:343:
< WARNING: C99 // comments do not match recommendation
< #344: FILE: /tmp/f1-15146/zebra_dplane.c:344:
< WARNING: C99 // comments do not match recommendation
< #346: FILE: /tmp/f1-15146/zebra_dplane.c:346:
< WARNING: C99 // comments do not match recommendation
< #347: FILE: /tmp/f1-15146/zebra_dplane.c:347:
< ERROR: "foo * bar" should be "foo *bar"
< #1492: FILE: /tmp/f1-15146/zebra_dplane.c:1492:
< WARNING: line over 80 characters
< #1499: FILE: /tmp/f1-15146/zebra_dplane.c:1499:
< ERROR: "foo * bar" should be "foo *bar"
< #1499: FILE: /tmp/f1-15146/zebra_dplane.c:1499:
< WARNING: line over 80 characters
< #2386: FILE: /tmp/f1-15146/zebra_dplane.c:2386:
< WARNING: C99 // comments do not match recommendation
< #2795: FILE: /tmp/f1-15146/zebra_dplane.c:2795:
< ERROR: else should follow close brace '}'
< #3546: FILE: /tmp/f1-15146/zebra_dplane.c:3546:
< ERROR: Bad function definition - enum zebra_dplane_result dplane_tc_update() should probably be enum zebra_dplane_result dplane_tc_update(void)
< #3556: FILE: /tmp/f1-15146/zebra_dplane.c:3556:
< WARNING: C99 // comments do not match recommendation
< #5695: FILE: /tmp/f1-15146/zebra_dplane.c:5695:
Report for zebra_dplane.h | 8 issues
===============================================
< WARNING: line over 80 characters
< #390: FILE: /tmp/f1-15146/zebra_dplane.h:390:
< ERROR: "foo * bar" should be "foo *bar"
< #390: FILE: /tmp/f1-15146/zebra_dplane.h:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-15146/zebra_dplane.h:391:
< ERROR: "foo * bar" should be "foo *bar"
< #391: FILE: /tmp/f1-15146/zebra_dplane.h:391:
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
NetBSD 9 amd64 build: Failed (click for details)
NetBSD 9 amd64 build: Unknown LogMake failed for NetBSD 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI012BUILD/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10363: zebra/tc_netlink.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:16968: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI012BUILD/config.status/config.status
FreeBSD 12 amd64 build: Failed (click for details)
Make failed for FreeBSD 12 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/FBSD12AMD64/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10359: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6743/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6372: all] Error 2
FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/FBSD12AMD64/config.status/config.status FreeBSD 12 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/FBSD12AMD64/config.log/config.log.gz
Fedora 29 amd64 build: Failed (click for details)
Fedora 29 amd64 build: Unknown LogUbuntu 16.04 i386 build: Failed (click for details)
Make failed for Ubuntu 16.04 i386 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U1604I386/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U1604I386/config.log/config.log.gz
OpenBSD 7 amd64 build: Failed (click for details)
Make failed for OpenBSD 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI011BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: 'linux/if_ether.h' file not found
#include <linux/if_ether.h>
1 error generated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.6743/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI011BUILD/config.status/config.status OpenBSD 7 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI011BUILD/config.log/config.log.gz
Redhat 8 amd64 build: Failed (click for details)
Redhat 8 amd64 build: Unknown LogCentOS 7 amd64 build: Failed (click for details)
CentOS 7 amd64 build: Unknown LogUbuntu 16.04 arm7 build: Failed (click for details)
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown LogMake failed for Ubuntu 16.04 arm7 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI101BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
FreeBSD 11 amd64 build: Failed (click for details)
Make failed for FreeBSD 11 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI009BUILD/ErrorLog/log_make.txt)
/usr/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/usr/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6743/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI009BUILD/config.status/config.status FreeBSD 11 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI009BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: Failed (click for details)
Make failed for Ubuntu 16.04 arm8 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U16ARM8BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Failed (click for details)
Make failed for Ubuntu 16.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI014BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI014BUILD/config.log/config.log.gz
Redhat 9 amd64 build: Failed (click for details)
Redhat 9 amd64 build: Unknown LogSuccessful on other platforms/tests
- Ubuntu 18.04 i386 build
- Ubuntu 18.04 arm7 build
- Debian 11 amd64 build
- Ubuntu 18.04 arm8 build
- Debian 10 amd64 build
- Ubuntu 22.04 amd64 build
- Debian 9 amd64 build
- Ubuntu 18.04 amd64 build
- Ubuntu 18.04 ppc64le build
- Ubuntu 20.04 amd64 build
Warnings Generated during build:
Checkout code: Successful with additional warnings
NetBSD 9 amd64 build: Failed (click for details)
NetBSD 9 amd64 build: Unknown LogMake failed for NetBSD 9 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI012BUILD/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10363: zebra/tc_netlink.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:16968: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI012BUILD/config.status/config.status
FreeBSD 12 amd64 build: Failed (click for details)
Make failed for FreeBSD 12 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/FBSD12AMD64/ErrorLog/log_make.txt)
CPP_NOTICE("Time to remove ospf6Enabled from JSON output")
^~~~~~~~~~
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
#include <linux/if_ether.h>
compilation terminated.
gmake[1]: *** [Makefile:10359: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6743/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6372: all] Error 2
FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/FBSD12AMD64/config.status/config.status FreeBSD 12 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/FBSD12AMD64/config.log/config.log.gz
Fedora 29 amd64 build: Failed (click for details)
Fedora 29 amd64 build: Unknown LogUbuntu 16.04 i386 build: Failed (click for details)
Make failed for Ubuntu 16.04 i386 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U1604I386/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U1604I386/config.log/config.log.gz
OpenBSD 7 amd64 build: Failed (click for details)
Make failed for OpenBSD 7 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI011BUILD/ErrorLog/log_make.txt)
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: 'linux/if_ether.h' file not found
#include <linux/if_ether.h>
1 error generated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.6743/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI011BUILD/config.status/config.status OpenBSD 7 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI011BUILD/config.log/config.log.gz
Redhat 8 amd64 build: Failed (click for details)
Redhat 8 amd64 build: Unknown LogCentOS 7 amd64 build: Failed (click for details)
CentOS 7 amd64 build: Unknown LogUbuntu 16.04 arm7 build: Failed (click for details)
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown LogMake failed for Ubuntu 16.04 arm7 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI101BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
FreeBSD 11 amd64 build: Failed (click for details)
Make failed for FreeBSD 11 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI009BUILD/ErrorLog/log_make.txt)
/usr/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:736: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
/usr/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:1486: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/tc_netlink.c:24:10: fatal error: linux/if_ether.h: No such file or directory
compilation terminated.
gmake[1]: *** [Makefile:10362: zebra/tc_netlink.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.6743/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6375: all] Error 2
FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI009BUILD/config.status/config.status FreeBSD 11 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI009BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: Failed (click for details)
Make failed for Ubuntu 16.04 arm8 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/U16ARM8BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Failed (click for details)
Make failed for Ubuntu 16.04 amd64 build: (see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI014BUILD/ErrorLog/log_make.txt)
make[1]: Entering directory '/home/ci/cibuild.6743/frr-source'
zebra/tc_netlink.c: In function netlink_tfilter_msg_encode:
zebra/tc_netlink.c:415:34: error: TCA_FLOWER_FLAGS undeclared (first use in this function)
zebra/tc_netlink.c:415:34: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9697: recipe for target 'zebra/tc_netlink.o' failed
make[1]: *** [zebra/tc_netlink.o] Error 1
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.6743/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6743/artifact/CI014BUILD/config.log/config.log.gz
Redhat 9 amd64 build: Failed (click for details)
Redhat 9 amd64 build: Unknown Log<stdin>:87: space before tab in indent.
break; /* should never hit here */
warning: 1 line adds whitespace errors.
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-17608/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-17608/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-17608/interface.c:1582:
Report for tc_netlink.c | 59 issues
===============================================
WARNING: C99 // comments do not match recommendation
#50: FILE: /tmp/f1-17608/tc_netlink.c:50:
+// TODO: move these bitflags to zebra_tc.h
WARNING: braces {} are not necessary for single statement blocks
#80: FILE: /tmp/f1-17608/tc_netlink.c:80:
+ if (freq) {
+ return freq;
+ }
WARNING: braces {} are not necessary for single statement blocks
#114: FILE: /tmp/f1-17608/tc_netlink.c:114:
+ for (int i = 0; i < 256; i++) {
+ table[i] = xmittime(ratespec->rate, (i + 1) << cell_log);
+ }
WARNING: Missing a blank line after declarations
#228: FILE: /tmp/f1-17608/tc_netlink.c:228:
+ const char *kind = "htb";
+ nl_attr_put(&req->n, datalen, TCA_KIND, kind, strlen(kind) + 1);
WARNING: Missing a blank line after declarations
#230: FILE: /tmp/f1-17608/tc_netlink.c:230:
+ struct rtattr *nest = nl_attr_nest(&req->n, datalen, TCA_OPTIONS);
+ nl_attr_put(&req->n, datalen, TCA_HTB_INIT, &htb_glob,
WARNING: braces {} are not necessary for single statement blocks
#275: FILE: /tmp/f1-17608/tc_netlink.c:275:
+ if (ceil < rate) {
+ ceil = rate;
+ }
WARNING: C99 // comments do not match recommendation
#282: FILE: /tmp/f1-17608/tc_netlink.c:282:
+ // TODO: fetch mtu from interface
WARNING: C99 // comments do not match recommendation
#353: FILE: /tmp/f1-17608/tc_netlink.c:353:
+ // TODO: priority support
WARNING: Missing a blank line after declarations
#357: FILE: /tmp/f1-17608/tc_netlink.c:357:
+ uint16_t protocol = htons(ETH_P_IP);
+ req->t.tcm_info = tc_make_handle(priority, protocol);
WARNING: Missing a blank line after declarations
#360: FILE: /tmp/f1-17608/tc_netlink.c:360:
+ uint32_t classid = tc_get_handle(ctx, 1);
+ req->t.tcm_handle = 1;
WARNING: Missing a blank line after declarations
#415: FILE: /tmp/f1-17608/tc_netlink.c:415:
+ uint32_t flags = 0;
+ nl_attr_put32(&req->n, datalen, TCA_FLOWER_FLAGS, flags);
WARNING: C99 // comments do not match recommendation
#444: FILE: /tmp/f1-17608/tc_netlink.c:444:
+ // TODO: error handling and other actions (delete, replace, ...)
Report for zebra_dplane.c | 40 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #324: FILE: /tmp/f1-17608/zebra_dplane.c:324:
< WARNING: C99 // comments do not match recommendation
< #325: FILE: /tmp/f1-17608/zebra_dplane.c:325:
< WARNING: C99 // comments do not match recommendation
< #326: FILE: /tmp/f1-17608/zebra_dplane.c:326:
< WARNING: C99 // comments do not match recommendation
< #334: FILE: /tmp/f1-17608/zebra_dplane.c:334:
< WARNING: C99 // comments do not match recommendation
< #336: FILE: /tmp/f1-17608/zebra_dplane.c:336:
< WARNING: C99 // comments do not match recommendation
< #337: FILE: /tmp/f1-17608/zebra_dplane.c:337:
< WARNING: C99 // comments do not match recommendation
< #340: FILE: /tmp/f1-17608/zebra_dplane.c:340:
< WARNING: C99 // comments do not match recommendation
< #341: FILE: /tmp/f1-17608/zebra_dplane.c:341:
< WARNING: C99 // comments do not match recommendation
< #343: FILE: /tmp/f1-17608/zebra_dplane.c:343:
< WARNING: C99 // comments do not match recommendation
< #344: FILE: /tmp/f1-17608/zebra_dplane.c:344:
< WARNING: C99 // comments do not match recommendation
< #346: FILE: /tmp/f1-17608/zebra_dplane.c:346:
< WARNING: C99 // comments do not match recommendation
< #347: FILE: /tmp/f1-17608/zebra_dplane.c:347:
< ERROR: "foo * bar" should be "foo *bar"
< #1492: FILE: /tmp/f1-17608/zebra_dplane.c:1492:
< WARNING: line over 80 characters
< #1499: FILE: /tmp/f1-17608/zebra_dplane.c:1499:
< ERROR: "foo * bar" should be "foo *bar"
< #1499: FILE: /tmp/f1-17608/zebra_dplane.c:1499:
< WARNING: line over 80 characters
< #2386: FILE: /tmp/f1-17608/zebra_dplane.c:2386:
< WARNING: C99 // comments do not match recommendation
< #2795: FILE: /tmp/f1-17608/zebra_dplane.c:2795:
< ERROR: else should follow close brace '}'
< #3546: FILE: /tmp/f1-17608/zebra_dplane.c:3546:
< ERROR: Bad function definition - enum zebra_dplane_result dplane_tc_update() should probably be enum zebra_dplane_result dplane_tc_update(void)
< #3556: FILE: /tmp/f1-17608/zebra_dplane.c:3556:
< WARNING: C99 // comments do not match recommendation
< #5695: FILE: /tmp/f1-17608/zebra_dplane.c:5695:
Report for zebra_dplane.h | 8 issues
===============================================
< WARNING: line over 80 characters
< #390: FILE: /tmp/f1-17608/zebra_dplane.h:390:
< ERROR: "foo * bar" should be "foo *bar"
< #390: FILE: /tmp/f1-17608/zebra_dplane.h:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-17608/zebra_dplane.h:391:
< ERROR: "foo * bar" should be "foo *bar"
< #391: FILE: /tmp/f1-17608/zebra_dplane.h:391:
looks like we need /usr/include/linux/pkt_cls.h
in FRR's local ./include directory
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6744/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Failed
Fedora 29 amd64 build: Failed (click for details)
Fedora 29 amd64 build: Unknown LogRedhat 8 amd64 build: Failed (click for details)
Redhat 8 amd64 build: Unknown LogCentOS 7 amd64 build: Failed (click for details)
CentOS 7 amd64 build: Unknown LogRedhat 9 amd64 build: Failed (click for details)
Redhat 9 amd64 build: Unknown LogSuccessful on other platforms/tests
- Ubuntu 18.04 ppc64le build
- NetBSD 9 amd64 build
- FreeBSD 12 amd64 build
- Ubuntu 16.04 i386 build
- Ubuntu 18.04 arm7 build
- Debian 11 amd64 build
- Ubuntu 18.04 arm8 build
- Debian 10 amd64 build
- OpenBSD 7 amd64 build
- Ubuntu 16.04 arm7 build
- Ubuntu 18.04 i386 build
- Ubuntu 18.04 amd64 build
- Ubuntu 22.04 amd64 build
- FreeBSD 11 amd64 build
- Debian 9 amd64 build
- Ubuntu 16.04 arm8 build
- Ubuntu 20.04 amd64 build
- Ubuntu 16.04 amd64 build
Warnings Generated during build:
Checkout code: Successful with additional warnings
Fedora 29 amd64 build: Failed (click for details)
Fedora 29 amd64 build: Unknown LogRedhat 8 amd64 build: Failed (click for details)
Redhat 8 amd64 build: Unknown LogCentOS 7 amd64 build: Failed (click for details)
CentOS 7 amd64 build: Unknown LogRedhat 9 amd64 build: Failed (click for details)
Redhat 9 amd64 build: Unknown Log<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
<stdin>:869: space before tab in indent.
break; /* should never hit here */
warning: 2 lines add whitespace errors.
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-12192/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-12192/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-12192/interface.c:1582:
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-12192/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-12192/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-12192/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-12192/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-12192/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-12192/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
Report for tc_netlink.c | 59 issues
===============================================
WARNING: C99 // comments do not match recommendation
#51: FILE: /tmp/f1-12192/tc_netlink.c:51:
+// TODO: move these bitflags to zebra_tc.h
WARNING: braces {} are not necessary for single statement blocks
#81: FILE: /tmp/f1-12192/tc_netlink.c:81:
+ if (freq) {
+ return freq;
+ }
WARNING: braces {} are not necessary for single statement blocks
#115: FILE: /tmp/f1-12192/tc_netlink.c:115:
+ for (int i = 0; i < 256; i++) {
+ table[i] = xmittime(ratespec->rate, (i + 1) << cell_log);
+ }
WARNING: Missing a blank line after declarations
#229: FILE: /tmp/f1-12192/tc_netlink.c:229:
+ const char *kind = "htb";
+ nl_attr_put(&req->n, datalen, TCA_KIND, kind, strlen(kind) + 1);
WARNING: Missing a blank line after declarations
#231: FILE: /tmp/f1-12192/tc_netlink.c:231:
+ struct rtattr *nest = nl_attr_nest(&req->n, datalen, TCA_OPTIONS);
+ nl_attr_put(&req->n, datalen, TCA_HTB_INIT, &htb_glob,
WARNING: braces {} are not necessary for single statement blocks
#276: FILE: /tmp/f1-12192/tc_netlink.c:276:
+ if (ceil < rate) {
+ ceil = rate;
+ }
WARNING: C99 // comments do not match recommendation
#283: FILE: /tmp/f1-12192/tc_netlink.c:283:
+ // TODO: fetch mtu from interface
WARNING: C99 // comments do not match recommendation
#354: FILE: /tmp/f1-12192/tc_netlink.c:354:
+ // TODO: priority support
WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-12192/tc_netlink.c:358:
+ uint16_t protocol = htons(ETH_P_IP);
+ req->t.tcm_info = tc_make_handle(priority, protocol);
WARNING: Missing a blank line after declarations
#361: FILE: /tmp/f1-12192/tc_netlink.c:361:
+ uint32_t classid = tc_get_handle(ctx, 1);
+ req->t.tcm_handle = 1;
WARNING: Missing a blank line after declarations
#416: FILE: /tmp/f1-12192/tc_netlink.c:416:
+ uint32_t flags = 0;
+ nl_attr_put32(&req->n, datalen, TCA_FLOWER_FLAGS, flags);
WARNING: C99 // comments do not match recommendation
#445: FILE: /tmp/f1-12192/tc_netlink.c:445:
+ // TODO: error handling and other actions (delete, replace, ...)
Report for zebra_dplane.c | 40 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #324: FILE: /tmp/f1-12192/zebra_dplane.c:324:
< WARNING: C99 // comments do not match recommendation
< #325: FILE: /tmp/f1-12192/zebra_dplane.c:325:
< WARNING: C99 // comments do not match recommendation
< #326: FILE: /tmp/f1-12192/zebra_dplane.c:326:
< WARNING: C99 // comments do not match recommendation
< #334: FILE: /tmp/f1-12192/zebra_dplane.c:334:
< WARNING: C99 // comments do not match recommendation
< #336: FILE: /tmp/f1-12192/zebra_dplane.c:336:
< WARNING: C99 // comments do not match recommendation
< #337: FILE: /tmp/f1-12192/zebra_dplane.c:337:
< WARNING: C99 // comments do not match recommendation
< #340: FILE: /tmp/f1-12192/zebra_dplane.c:340:
< WARNING: C99 // comments do not match recommendation
< #341: FILE: /tmp/f1-12192/zebra_dplane.c:341:
< WARNING: C99 // comments do not match recommendation
< #343: FILE: /tmp/f1-12192/zebra_dplane.c:343:
< WARNING: C99 // comments do not match recommendation
< #344: FILE: /tmp/f1-12192/zebra_dplane.c:344:
< WARNING: C99 // comments do not match recommendation
< #346: FILE: /tmp/f1-12192/zebra_dplane.c:346:
< WARNING: C99 // comments do not match recommendation
< #347: FILE: /tmp/f1-12192/zebra_dplane.c:347:
< ERROR: "foo * bar" should be "foo *bar"
< #1492: FILE: /tmp/f1-12192/zebra_dplane.c:1492:
< WARNING: line over 80 characters
< #1499: FILE: /tmp/f1-12192/zebra_dplane.c:1499:
< ERROR: "foo * bar" should be "foo *bar"
< #1499: FILE: /tmp/f1-12192/zebra_dplane.c:1499:
< WARNING: line over 80 characters
< #2386: FILE: /tmp/f1-12192/zebra_dplane.c:2386:
< WARNING: C99 // comments do not match recommendation
< #2795: FILE: /tmp/f1-12192/zebra_dplane.c:2795:
< ERROR: else should follow close brace '}'
< #3546: FILE: /tmp/f1-12192/zebra_dplane.c:3546:
< ERROR: Bad function definition - enum zebra_dplane_result dplane_tc_update() should probably be enum zebra_dplane_result dplane_tc_update(void)
< #3556: FILE: /tmp/f1-12192/zebra_dplane.c:3556:
< WARNING: C99 // comments do not match recommendation
< #5695: FILE: /tmp/f1-12192/zebra_dplane.c:5695:
Report for zebra_dplane.h | 8 issues
===============================================
< WARNING: line over 80 characters
< #390: FILE: /tmp/f1-12192/zebra_dplane.h:390:
< ERROR: "foo * bar" should be "foo *bar"
< #390: FILE: /tmp/f1-12192/zebra_dplane.h:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-12192/zebra_dplane.h:391:
< ERROR: "foo * bar" should be "foo *bar"
< #391: FILE: /tmp/f1-12192/zebra_dplane.h:391:
/home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/nhrpd.rst:248: WARNING: image file not readable: ../figures/fig_dmvpn_topologies.png
/home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/pathd.rst:14: WARNING: image file not readable: images/pathd_general.png
/home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/pathd.rst:129: WARNING: image file not readable: images/pathd_config.png
/home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/pathd.rst:176: WARNING: image file not readable: images/pathd_initiated_multi.png
zebra/kernel_netlink.c:50:10: fatal error: zebra/tc_netlink.h: No such file or directory
#include "zebra/tc_netlink.h"
^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:10364: zebra/kernel_netlink.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:6372: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.DvQe1B (%build)
Bad exit status from /var/tmp/rpm-tmp.DvQe1B (%build)
RPM rpmbuild failed
@sigeryang this is the failure being seen on fedora/redhat/centos
I am not sure why though....
/home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/nhrpd.rst:248: WARNING: image file not readable: ../figures/fig_dmvpn_topologies.png /home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/pathd.rst:14: WARNING: image file not readable: images/pathd_general.png /home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/pathd.rst:129: WARNING: image file not readable: images/pathd_config.png /home/ci/cibuild.6744/rpmwork/rpmbuild/BUILD/frr-8.4-dev-20220801-git.6c10666/doc/user/pathd.rst:176: WARNING: image file not readable: images/pathd_initiated_multi.png zebra/kernel_netlink.c:50:10: fatal error: zebra/tc_netlink.h: No such file or directory #include "zebra/tc_netlink.h" ^~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:10364: zebra/kernel_netlink.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:6372: all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.DvQe1B (%build) Bad exit status from /var/tmp/rpm-tmp.DvQe1B (%build) RPM rpmbuild failed
@sigeryang this is the failure being seen on fedora/redhat/centos
I am not sure why though....
Oh it might be because you don't have the header in your subdir.am I have a open comment about it in your code:
does the header need to be added at the bottom here as well?
Continuous Integration Result: SUCCESSFUL
Continuous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF / OpenSourceRouting.org CI System
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6804/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Warnings Generated during build:
Checkout code: Successful with additional warnings
<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
<stdin>:869: space before tab in indent.
break; /* should never hit here */
warning: 2 lines add whitespace errors.
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-19415/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-19415/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-19415/interface.c:1582:
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-19415/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-19415/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-19415/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-19415/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-19415/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-19415/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
Report for tc_netlink.c | 59 issues
===============================================
WARNING: C99 // comments do not match recommendation
#51: FILE: /tmp/f1-19415/tc_netlink.c:51:
+// TODO: move these bitflags to zebra_tc.h
WARNING: braces {} are not necessary for single statement blocks
#81: FILE: /tmp/f1-19415/tc_netlink.c:81:
+ if (freq) {
+ return freq;
+ }
WARNING: braces {} are not necessary for single statement blocks
#115: FILE: /tmp/f1-19415/tc_netlink.c:115:
+ for (int i = 0; i < 256; i++) {
+ table[i] = xmittime(ratespec->rate, (i + 1) << cell_log);
+ }
WARNING: Missing a blank line after declarations
#229: FILE: /tmp/f1-19415/tc_netlink.c:229:
+ const char *kind = "htb";
+ nl_attr_put(&req->n, datalen, TCA_KIND, kind, strlen(kind) + 1);
WARNING: Missing a blank line after declarations
#231: FILE: /tmp/f1-19415/tc_netlink.c:231:
+ struct rtattr *nest = nl_attr_nest(&req->n, datalen, TCA_OPTIONS);
+ nl_attr_put(&req->n, datalen, TCA_HTB_INIT, &htb_glob,
WARNING: braces {} are not necessary for single statement blocks
#276: FILE: /tmp/f1-19415/tc_netlink.c:276:
+ if (ceil < rate) {
+ ceil = rate;
+ }
WARNING: C99 // comments do not match recommendation
#283: FILE: /tmp/f1-19415/tc_netlink.c:283:
+ // TODO: fetch mtu from interface
WARNING: C99 // comments do not match recommendation
#354: FILE: /tmp/f1-19415/tc_netlink.c:354:
+ // TODO: priority support
WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-19415/tc_netlink.c:358:
+ uint16_t protocol = htons(ETH_P_IP);
+ req->t.tcm_info = tc_make_handle(priority, protocol);
WARNING: Missing a blank line after declarations
#361: FILE: /tmp/f1-19415/tc_netlink.c:361:
+ uint32_t classid = tc_get_handle(ctx, 1);
+ req->t.tcm_handle = 1;
WARNING: Missing a blank line after declarations
#416: FILE: /tmp/f1-19415/tc_netlink.c:416:
+ uint32_t flags = 0;
+ nl_attr_put32(&req->n, datalen, TCA_FLOWER_FLAGS, flags);
WARNING: C99 // comments do not match recommendation
#445: FILE: /tmp/f1-19415/tc_netlink.c:445:
+ // TODO: error handling and other actions (delete, replace, ...)
Report for zebra_dplane.c | 40 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #324: FILE: /tmp/f1-19415/zebra_dplane.c:324:
< WARNING: C99 // comments do not match recommendation
< #325: FILE: /tmp/f1-19415/zebra_dplane.c:325:
< WARNING: C99 // comments do not match recommendation
< #326: FILE: /tmp/f1-19415/zebra_dplane.c:326:
< WARNING: C99 // comments do not match recommendation
< #334: FILE: /tmp/f1-19415/zebra_dplane.c:334:
< WARNING: C99 // comments do not match recommendation
< #336: FILE: /tmp/f1-19415/zebra_dplane.c:336:
< WARNING: C99 // comments do not match recommendation
< #337: FILE: /tmp/f1-19415/zebra_dplane.c:337:
< WARNING: C99 // comments do not match recommendation
< #340: FILE: /tmp/f1-19415/zebra_dplane.c:340:
< WARNING: C99 // comments do not match recommendation
< #341: FILE: /tmp/f1-19415/zebra_dplane.c:341:
< WARNING: C99 // comments do not match recommendation
< #343: FILE: /tmp/f1-19415/zebra_dplane.c:343:
< WARNING: C99 // comments do not match recommendation
< #344: FILE: /tmp/f1-19415/zebra_dplane.c:344:
< WARNING: C99 // comments do not match recommendation
< #346: FILE: /tmp/f1-19415/zebra_dplane.c:346:
< WARNING: C99 // comments do not match recommendation
< #347: FILE: /tmp/f1-19415/zebra_dplane.c:347:
< ERROR: "foo * bar" should be "foo *bar"
< #1492: FILE: /tmp/f1-19415/zebra_dplane.c:1492:
< WARNING: line over 80 characters
< #1499: FILE: /tmp/f1-19415/zebra_dplane.c:1499:
< ERROR: "foo * bar" should be "foo *bar"
< #1499: FILE: /tmp/f1-19415/zebra_dplane.c:1499:
< WARNING: line over 80 characters
< #2386: FILE: /tmp/f1-19415/zebra_dplane.c:2386:
< WARNING: C99 // comments do not match recommendation
< #2795: FILE: /tmp/f1-19415/zebra_dplane.c:2795:
< ERROR: else should follow close brace '}'
< #3546: FILE: /tmp/f1-19415/zebra_dplane.c:3546:
< ERROR: Bad function definition - enum zebra_dplane_result dplane_tc_update() should probably be enum zebra_dplane_result dplane_tc_update(void)
< #3556: FILE: /tmp/f1-19415/zebra_dplane.c:3556:
< WARNING: C99 // comments do not match recommendation
< #5695: FILE: /tmp/f1-19415/zebra_dplane.c:5695:
Report for zebra_dplane.h | 8 issues
===============================================
< WARNING: line over 80 characters
< #390: FILE: /tmp/f1-19415/zebra_dplane.h:390:
< ERROR: "foo * bar" should be "foo *bar"
< #390: FILE: /tmp/f1-19415/zebra_dplane.h:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-19415/zebra_dplane.h:391:
< ERROR: "foo * bar" should be "foo *bar"
< #391: FILE: /tmp/f1-19415/zebra_dplane.h:391:
CLANG Static Analyzer Summary
- Github Pull Request 11694, comparing to Git base SHA b993483
- Base image data for Git b993483 does not exist - compare skipped
3 Static Analyzer issues remaining.
See details at https://ci1.netdef.org/browse/FRR-PULLREQ2-6804/artifact/shared/static_analysis/index.html
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6801/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Successful
Basic Tests: Failed
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)
Topotests Ubuntu 18.04 amd64 part 0: No useful log foundSuccessful on other platforms/tests
- Topotests Ubuntu 18.04 amd64 part 1
- Debian 9 deb pkg check
- Ubuntu 18.04 deb pkg check
- Addresssanitizer topotests part 1
- Ubuntu 20.04 deb pkg check
- Topotests Ubuntu 18.04 i386 part 4
- Topotests Ubuntu 18.04 amd64 part 8
- IPv4 protocols on Ubuntu 18.04
- Topotests debian 10 amd64 part 7
- Topotests Ubuntu 18.04 arm8 part 0
- Topotests Ubuntu 18.04 i386 part 8
- Addresssanitizer topotests part 8
- Topotests Ubuntu 18.04 amd64 part 9
- Debian 10 deb pkg check
- Topotests Ubuntu 18.04 amd64 part 6
- Topotests debian 10 amd64 part 1
- Topotests Ubuntu 18.04 arm8 part 3
- Addresssanitizer topotests part 5
- Topotests debian 10 amd64 part 4
- Addresssanitizer topotests part 4
- Topotests Ubuntu 18.04 arm8 part 5
- Topotests debian 10 amd64 part 2
- Topotests Ubuntu 18.04 i386 part 9
- Addresssanitizer topotests part 0
- Static analyzer (clang)
- Topotests debian 10 amd64 part 3
- Topotests debian 10 amd64 part 5
- Topotests debian 10 amd64 part 0
- Ubuntu 16.04 deb pkg check
- Topotests Ubuntu 18.04 arm8 part 2
- Topotests Ubuntu 18.04 arm8 part 7
- Topotests Ubuntu 18.04 i386 part 1
- Topotests Ubuntu 18.04 amd64 part 4
- Addresssanitizer topotests part 9
- Topotests Ubuntu 18.04 i386 part 6
- IPv4 ldp protocol on Ubuntu 18.04
- Topotests Ubuntu 18.04 i386 part 2
- Topotests Ubuntu 18.04 arm8 part 6
- Topotests debian 10 amd64 part 6
- Topotests Ubuntu 18.04 arm8 part 1
- Addresssanitizer topotests part 7
- Topotests Ubuntu 18.04 arm8 part 8
- Topotests Ubuntu 18.04 i386 part 7
- Topotests Ubuntu 18.04 amd64 part 7
- Topotests Ubuntu 18.04 amd64 part 5
- Addresssanitizer topotests part 6
- Topotests Ubuntu 18.04 i386 part 5
- Addresssanitizer topotests part 3
- Topotests Ubuntu 18.04 i386 part 0
- Topotests Ubuntu 18.04 amd64 part 2
- Topotests Ubuntu 18.04 i386 part 3
- CentOS 7 rpm pkg check
- Fedora 29 rpm pkg check
- Topotests debian 10 amd64 part 8
- Topotests Ubuntu 18.04 arm8 part 4
- Topotests debian 10 amd64 part 9
- Topotests Ubuntu 18.04 arm8 part 9
- Addresssanitizer topotests part 2
- Topotests Ubuntu 18.04 amd64 part 3
- IPv6 protocols on Ubuntu 18.04
Warnings Generated during build:
Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)
Topotests Ubuntu 18.04 amd64 part 0: No useful log found<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
<stdin>:869: space before tab in indent.
break; /* should never hit here */
warning: 2 lines add whitespace errors.
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-26614/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-26614/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-26614/interface.c:1582:
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-26614/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-26614/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-26614/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-26614/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-26614/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-26614/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
Report for tc_netlink.c | 59 issues
===============================================
WARNING: C99 // comments do not match recommendation
#51: FILE: /tmp/f1-26614/tc_netlink.c:51:
+// TODO: move these bitflags to zebra_tc.h
WARNING: braces {} are not necessary for single statement blocks
#81: FILE: /tmp/f1-26614/tc_netlink.c:81:
+ if (freq) {
+ return freq;
+ }
WARNING: braces {} are not necessary for single statement blocks
#115: FILE: /tmp/f1-26614/tc_netlink.c:115:
+ for (int i = 0; i < 256; i++) {
+ table[i] = xmittime(ratespec->rate, (i + 1) << cell_log);
+ }
WARNING: Missing a blank line after declarations
#229: FILE: /tmp/f1-26614/tc_netlink.c:229:
+ const char *kind = "htb";
+ nl_attr_put(&req->n, datalen, TCA_KIND, kind, strlen(kind) + 1);
WARNING: Missing a blank line after declarations
#231: FILE: /tmp/f1-26614/tc_netlink.c:231:
+ struct rtattr *nest = nl_attr_nest(&req->n, datalen, TCA_OPTIONS);
+ nl_attr_put(&req->n, datalen, TCA_HTB_INIT, &htb_glob,
WARNING: braces {} are not necessary for single statement blocks
#276: FILE: /tmp/f1-26614/tc_netlink.c:276:
+ if (ceil < rate) {
+ ceil = rate;
+ }
WARNING: C99 // comments do not match recommendation
#283: FILE: /tmp/f1-26614/tc_netlink.c:283:
+ // TODO: fetch mtu from interface
WARNING: C99 // comments do not match recommendation
#354: FILE: /tmp/f1-26614/tc_netlink.c:354:
+ // TODO: priority support
WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-26614/tc_netlink.c:358:
+ uint16_t protocol = htons(ETH_P_IP);
+ req->t.tcm_info = tc_make_handle(priority, protocol);
WARNING: Missing a blank line after declarations
#361: FILE: /tmp/f1-26614/tc_netlink.c:361:
+ uint32_t classid = tc_get_handle(ctx, 1);
+ req->t.tcm_handle = 1;
WARNING: Missing a blank line after declarations
#416: FILE: /tmp/f1-26614/tc_netlink.c:416:
+ uint32_t flags = 0;
+ nl_attr_put32(&req->n, datalen, TCA_FLOWER_FLAGS, flags);
WARNING: C99 // comments do not match recommendation
#445: FILE: /tmp/f1-26614/tc_netlink.c:445:
+ // TODO: error handling and other actions (delete, replace, ...)
Report for zebra_dplane.c | 40 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #324: FILE: /tmp/f1-26614/zebra_dplane.c:324:
< WARNING: C99 // comments do not match recommendation
< #325: FILE: /tmp/f1-26614/zebra_dplane.c:325:
< WARNING: C99 // comments do not match recommendation
< #326: FILE: /tmp/f1-26614/zebra_dplane.c:326:
< WARNING: C99 // comments do not match recommendation
< #334: FILE: /tmp/f1-26614/zebra_dplane.c:334:
< WARNING: C99 // comments do not match recommendation
< #336: FILE: /tmp/f1-26614/zebra_dplane.c:336:
< WARNING: C99 // comments do not match recommendation
< #337: FILE: /tmp/f1-26614/zebra_dplane.c:337:
< WARNING: C99 // comments do not match recommendation
< #340: FILE: /tmp/f1-26614/zebra_dplane.c:340:
< WARNING: C99 // comments do not match recommendation
< #341: FILE: /tmp/f1-26614/zebra_dplane.c:341:
< WARNING: C99 // comments do not match recommendation
< #343: FILE: /tmp/f1-26614/zebra_dplane.c:343:
< WARNING: C99 // comments do not match recommendation
< #344: FILE: /tmp/f1-26614/zebra_dplane.c:344:
< WARNING: C99 // comments do not match recommendation
< #346: FILE: /tmp/f1-26614/zebra_dplane.c:346:
< WARNING: C99 // comments do not match recommendation
< #347: FILE: /tmp/f1-26614/zebra_dplane.c:347:
< ERROR: "foo * bar" should be "foo *bar"
< #1492: FILE: /tmp/f1-26614/zebra_dplane.c:1492:
< WARNING: line over 80 characters
< #1499: FILE: /tmp/f1-26614/zebra_dplane.c:1499:
< ERROR: "foo * bar" should be "foo *bar"
< #1499: FILE: /tmp/f1-26614/zebra_dplane.c:1499:
< WARNING: line over 80 characters
< #2386: FILE: /tmp/f1-26614/zebra_dplane.c:2386:
< WARNING: C99 // comments do not match recommendation
< #2795: FILE: /tmp/f1-26614/zebra_dplane.c:2795:
< ERROR: else should follow close brace '}'
< #3546: FILE: /tmp/f1-26614/zebra_dplane.c:3546:
< ERROR: Bad function definition - enum zebra_dplane_result dplane_tc_update() should probably be enum zebra_dplane_result dplane_tc_update(void)
< #3556: FILE: /tmp/f1-26614/zebra_dplane.c:3556:
< WARNING: C99 // comments do not match recommendation
< #5695: FILE: /tmp/f1-26614/zebra_dplane.c:5695:
Report for zebra_dplane.h | 8 issues
===============================================
< WARNING: line over 80 characters
< #390: FILE: /tmp/f1-26614/zebra_dplane.h:390:
< ERROR: "foo * bar" should be "foo *bar"
< #390: FILE: /tmp/f1-26614/zebra_dplane.h:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-26614/zebra_dplane.h:391:
< ERROR: "foo * bar" should be "foo *bar"
< #391: FILE: /tmp/f1-26614/zebra_dplane.h:391:
CLANG Static Analyzer Summary
- Github Pull Request 11694, comparing to Git base SHA b993483
- Base image data for Git b993483 does not exist - compare skipped
3 Static Analyzer issues remaining.
See details at https://ci1.netdef.org/browse/FRR-PULLREQ2-6801/artifact/shared/static_analysis/index.html
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6806/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Successful
Basic Tests: Failed
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)
Topotests Ubuntu 18.04 amd64 part 7: No useful log foundSuccessful on other platforms/tests
- Topotests Ubuntu 18.04 i386 part 4
- IPv4 protocols on Ubuntu 18.04
- Topotests Ubuntu 18.04 amd64 part 1
- Static analyzer (clang)
- Topotests Ubuntu 18.04 amd64 part 9
- Topotests debian 10 amd64 part 7
- Topotests Ubuntu 18.04 arm8 part 0
- Debian 9 deb pkg check
- Topotests Ubuntu 18.04 amd64 part 8
- Topotests debian 10 amd64 part 2
- Addresssanitizer topotests part 8
- Topotests Ubuntu 18.04 arm8 part 5
- Debian 10 deb pkg check
- Topotests Ubuntu 18.04 amd64 part 6
- Ubuntu 18.04 deb pkg check
- Addresssanitizer topotests part 6
- Ubuntu 20.04 deb pkg check
- Addresssanitizer topotests part 5
- Topotests debian 10 amd64 part 6
- Topotests debian 10 amd64 part 1
- Addresssanitizer topotests part 4
- Addresssanitizer topotests part 0
- Topotests debian 10 amd64 part 3
- Topotests debian 10 amd64 part 4
- Topotests Ubuntu 18.04 i386 part 9
- Topotests Ubuntu 18.04 arm8 part 3
- Addresssanitizer topotests part 1
- Topotests Ubuntu 18.04 arm8 part 7
- Addresssanitizer topotests part 9
- Topotests debian 10 amd64 part 0
- IPv4 ldp protocol on Ubuntu 18.04
- Topotests debian 10 amd64 part 5
- Topotests Ubuntu 18.04 arm8 part 2
- Ubuntu 16.04 deb pkg check
- Topotests Ubuntu 18.04 i386 part 7
- Addresssanitizer topotests part 7
- Topotests Ubuntu 18.04 arm8 part 8
- Topotests Ubuntu 18.04 i386 part 6
- Topotests Ubuntu 18.04 i386 part 1
- Topotests Ubuntu 18.04 arm8 part 6
- Topotests Ubuntu 18.04 i386 part 2
- Topotests Ubuntu 18.04 amd64 part 5
- Topotests Ubuntu 18.04 arm8 part 1
- Addresssanitizer topotests part 3
- Fedora 29 rpm pkg check
- Topotests Ubuntu 18.04 i386 part 5
- Topotests Ubuntu 18.04 i386 part 0
- Topotests Ubuntu 18.04 i386 part 8
- Topotests Ubuntu 18.04 i386 part 3
- Topotests Ubuntu 18.04 amd64 part 2
- Topotests debian 10 amd64 part 8
- IPv6 protocols on Ubuntu 18.04
- Topotests Ubuntu 18.04 amd64 part 4
- Topotests Ubuntu 18.04 arm8 part 4
- CentOS 7 rpm pkg check
- Topotests Ubuntu 18.04 amd64 part 0
- Topotests Ubuntu 18.04 amd64 part 3
- Topotests Ubuntu 18.04 arm8 part 9
- Addresssanitizer topotests part 2
- Topotests debian 10 amd64 part 9
Warnings Generated during build:
Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)
Topotests Ubuntu 18.04 amd64 part 7: No useful log found<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
<stdin>:869: space before tab in indent.
break; /* should never hit here */
warning: 2 lines add whitespace errors.
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-32206/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-32206/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-32206/interface.c:1582:
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-32206/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-32206/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-32206/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-32206/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-32206/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-32206/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
Report for tc_netlink.c | 59 issues
===============================================
WARNING: C99 // comments do not match recommendation
#51: FILE: /tmp/f1-32206/tc_netlink.c:51:
+// TODO: move these bitflags to zebra_tc.h
WARNING: braces {} are not necessary for single statement blocks
#81: FILE: /tmp/f1-32206/tc_netlink.c:81:
+ if (freq) {
+ return freq;
+ }
WARNING: braces {} are not necessary for single statement blocks
#115: FILE: /tmp/f1-32206/tc_netlink.c:115:
+ for (int i = 0; i < 256; i++) {
+ table[i] = xmittime(ratespec->rate, (i + 1) << cell_log);
+ }
WARNING: Missing a blank line after declarations
#229: FILE: /tmp/f1-32206/tc_netlink.c:229:
+ const char *kind = "htb";
+ nl_attr_put(&req->n, datalen, TCA_KIND, kind, strlen(kind) + 1);
WARNING: Missing a blank line after declarations
#231: FILE: /tmp/f1-32206/tc_netlink.c:231:
+ struct rtattr *nest = nl_attr_nest(&req->n, datalen, TCA_OPTIONS);
+ nl_attr_put(&req->n, datalen, TCA_HTB_INIT, &htb_glob,
WARNING: braces {} are not necessary for single statement blocks
#276: FILE: /tmp/f1-32206/tc_netlink.c:276:
+ if (ceil < rate) {
+ ceil = rate;
+ }
WARNING: C99 // comments do not match recommendation
#283: FILE: /tmp/f1-32206/tc_netlink.c:283:
+ // TODO: fetch mtu from interface
WARNING: C99 // comments do not match recommendation
#354: FILE: /tmp/f1-32206/tc_netlink.c:354:
+ // TODO: priority support
WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-32206/tc_netlink.c:358:
+ uint16_t protocol = htons(ETH_P_IP);
+ req->t.tcm_info = tc_make_handle(priority, protocol);
WARNING: Missing a blank line after declarations
#361: FILE: /tmp/f1-32206/tc_netlink.c:361:
+ uint32_t classid = tc_get_handle(ctx, 1);
+ req->t.tcm_handle = 1;
WARNING: Missing a blank line after declarations
#416: FILE: /tmp/f1-32206/tc_netlink.c:416:
+ uint32_t flags = 0;
+ nl_attr_put32(&req->n, datalen, TCA_FLOWER_FLAGS, flags);
WARNING: C99 // comments do not match recommendation
#445: FILE: /tmp/f1-32206/tc_netlink.c:445:
+ // TODO: error handling and other actions (delete, replace, ...)
Report for zebra_dplane.c | 40 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #324: FILE: /tmp/f1-32206/zebra_dplane.c:324:
< WARNING: C99 // comments do not match recommendation
< #325: FILE: /tmp/f1-32206/zebra_dplane.c:325:
< WARNING: C99 // comments do not match recommendation
< #326: FILE: /tmp/f1-32206/zebra_dplane.c:326:
< WARNING: C99 // comments do not match recommendation
< #334: FILE: /tmp/f1-32206/zebra_dplane.c:334:
< WARNING: C99 // comments do not match recommendation
< #336: FILE: /tmp/f1-32206/zebra_dplane.c:336:
< WARNING: C99 // comments do not match recommendation
< #337: FILE: /tmp/f1-32206/zebra_dplane.c:337:
< WARNING: C99 // comments do not match recommendation
< #340: FILE: /tmp/f1-32206/zebra_dplane.c:340:
< WARNING: C99 // comments do not match recommendation
< #341: FILE: /tmp/f1-32206/zebra_dplane.c:341:
< WARNING: C99 // comments do not match recommendation
< #343: FILE: /tmp/f1-32206/zebra_dplane.c:343:
< WARNING: C99 // comments do not match recommendation
< #344: FILE: /tmp/f1-32206/zebra_dplane.c:344:
< WARNING: C99 // comments do not match recommendation
< #346: FILE: /tmp/f1-32206/zebra_dplane.c:346:
< WARNING: C99 // comments do not match recommendation
< #347: FILE: /tmp/f1-32206/zebra_dplane.c:347:
< ERROR: "foo * bar" should be "foo *bar"
< #1492: FILE: /tmp/f1-32206/zebra_dplane.c:1492:
< WARNING: line over 80 characters
< #1499: FILE: /tmp/f1-32206/zebra_dplane.c:1499:
< ERROR: "foo * bar" should be "foo *bar"
< #1499: FILE: /tmp/f1-32206/zebra_dplane.c:1499:
< WARNING: line over 80 characters
< #2386: FILE: /tmp/f1-32206/zebra_dplane.c:2386:
< WARNING: C99 // comments do not match recommendation
< #2795: FILE: /tmp/f1-32206/zebra_dplane.c:2795:
< ERROR: else should follow close brace '}'
< #3546: FILE: /tmp/f1-32206/zebra_dplane.c:3546:
< ERROR: Bad function definition - enum zebra_dplane_result dplane_tc_update() should probably be enum zebra_dplane_result dplane_tc_update(void)
< #3556: FILE: /tmp/f1-32206/zebra_dplane.c:3556:
< WARNING: C99 // comments do not match recommendation
< #5695: FILE: /tmp/f1-32206/zebra_dplane.c:5695:
Report for zebra_dplane.h | 8 issues
===============================================
< WARNING: line over 80 characters
< #390: FILE: /tmp/f1-32206/zebra_dplane.h:390:
< ERROR: "foo * bar" should be "foo *bar"
< #390: FILE: /tmp/f1-32206/zebra_dplane.h:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-32206/zebra_dplane.h:391:
< ERROR: "foo * bar" should be "foo *bar"
< #391: FILE: /tmp/f1-32206/zebra_dplane.h:391:
CLANG Static Analyzer Summary
- Github Pull Request 11694, comparing to Git base SHA b993483
- Base image data for Git b993483 does not exist - compare skipped
3 Static Analyzer issues remaining.
See details at https://ci1.netdef.org/browse/FRR-PULLREQ2-6806/artifact/shared/static_analysis/index.html
Continuous Integration Result: FAILED
Continuous Integration Result: FAILED
See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6808/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Get source / Pull Request: Successful
Building Stage: Successful
Basic Tests: Failed
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)
Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)
Topotests Ubuntu 18.04 i386 part 9: Unknown LogTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)
Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
- Topotests Ubuntu 18.04 amd64 part 8
- Topotests debian 10 amd64 part 7
- IPv4 protocols on Ubuntu 18.04
- Static analyzer (clang)
- Topotests Ubuntu 18.04 arm8 part 0
- Debian 9 deb pkg check
- Topotests Ubuntu 18.04 amd64 part 9
- Addresssanitizer topotests part 8
- Topotests debian 10 amd64 part 2
- Debian 10 deb pkg check
- Topotests Ubuntu 18.04 arm8 part 5
- Topotests Ubuntu 18.04 amd64 part 6
- Topotests Ubuntu 18.04 amd64 part 1
- Addresssanitizer topotests part 6
- Ubuntu 20.04 deb pkg check
- Ubuntu 18.04 deb pkg check
- Addresssanitizer topotests part 5
- Topotests debian 10 amd64 part 6
- Topotests debian 10 amd64 part 1
- Addresssanitizer topotests part 4
- Addresssanitizer topotests part 0
- Topotests debian 10 amd64 part 4
- Topotests debian 10 amd64 part 3
- Topotests Ubuntu 18.04 arm8 part 3
- Addresssanitizer topotests part 1
- Topotests Ubuntu 18.04 i386 part 4
- Topotests Ubuntu 18.04 arm8 part 7
- Addresssanitizer topotests part 9
- Topotests debian 10 amd64 part 0
- IPv4 ldp protocol on Ubuntu 18.04
- Ubuntu 16.04 deb pkg check
- Topotests Ubuntu 18.04 arm8 part 2
- Topotests debian 10 amd64 part 5
- Topotests Ubuntu 18.04 i386 part 1
- Addresssanitizer topotests part 7
- Topotests Ubuntu 18.04 arm8 part 8
- Topotests Ubuntu 18.04 i386 part 7
- Topotests Ubuntu 18.04 i386 part 6
- Topotests Ubuntu 18.04 amd64 part 5
- Topotests Ubuntu 18.04 i386 part 2
- Topotests Ubuntu 18.04 arm8 part 6
- Topotests Ubuntu 18.04 amd64 part 2
- Topotests Ubuntu 18.04 amd64 part 7
- Fedora 29 rpm pkg check
- Topotests Ubuntu 18.04 i386 part 8
- Topotests Ubuntu 18.04 i386 part 5
- Topotests Ubuntu 18.04 i386 part 3
- Addresssanitizer topotests part 3
- Topotests debian 10 amd64 part 8
- Topotests Ubuntu 18.04 i386 part 0
- Topotests Ubuntu 18.04 arm8 part 4
- IPv6 protocols on Ubuntu 18.04
- Topotests Ubuntu 18.04 amd64 part 4
- CentOS 7 rpm pkg check
- Addresssanitizer topotests part 2
- Topotests Ubuntu 18.04 amd64 part 3
- Topotests Ubuntu 18.04 amd64 part 0
- Topotests debian 10 amd64 part 9
Warnings Generated during build:
Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)
Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)
Topotests Ubuntu 18.04 i386 part 9: Unknown LogTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)
Topotests Ubuntu 18.04 arm8 part 9: No useful log found<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
<stdin>:869: space before tab in indent.
break; /* should never hit here */
warning: 2 lines add whitespace errors.
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-11210/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-11210/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-11210/interface.c:1582:
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-11210/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-11210/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-11210/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-11210/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-11210/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-11210/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
Report for tc_netlink.c | 59 issues
===============================================
WARNING: C99 // comments do not match recommendation
#51: FILE: /tmp/f1-11210/tc_netlink.c:51:
+// TODO: move these bitflags to zebra_tc.h
WARNING: braces {} are not necessary for single statement blocks
#81: FILE: /tmp/f1-11210/tc_netlink.c:81:
+ if (freq) {
+ return freq;
+ }
WARNING: braces {} are not necessary for single statement blocks
#115: FILE: /tmp/f1-11210/tc_netlink.c:115:
+ for (int i = 0; i < 256; i++) {
+ table[i] = xmittime(ratespec->rate, (i + 1) << cell_log);
+ }
WARNING: Missing a blank line after declarations
#229: FILE: /tmp/f1-11210/tc_netlink.c:229:
+ const char *kind = "htb";
+ nl_attr_put(&req->n, datalen, TCA_KIND, kind, strlen(kind) + 1);
WARNING: Missing a blank line after declarations
#231: FILE: /tmp/f1-11210/tc_netlink.c:231:
+ struct rtattr *nest = nl_attr_nest(&req->n, datalen, TCA_OPTIONS);
+ nl_attr_put(&req->n, datalen, TCA_HTB_INIT, &htb_glob,
WARNING: braces {} are not necessary for single statement blocks
#276: FILE: /tmp/f1-11210/tc_netlink.c:276:
+ if (ceil < rate) {
+ ceil = rate;
+ }
WARNING: C99 // comments do not match recommendation
#283: FILE: /tmp/f1-11210/tc_netlink.c:283:
+ // TODO: fetch mtu from interface
WARNING: C99 // comments do not match recommendation
#354: FILE: /tmp/f1-11210/tc_netlink.c:354:
+ // TODO: priority support
WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-11210/tc_netlink.c:358:
+ uint16_t protocol = htons(ETH_P_IP);
+ req->t.tcm_info = tc_make_handle(priority, protocol);
WARNING: Missing a blank line after declarations
#361: FILE: /tmp/f1-11210/tc_netlink.c:361:
+ uint32_t classid = tc_get_handle(ctx, 1);
+ req->t.tcm_handle = 1;
WARNING: Missing a blank line after declarations
#416: FILE: /tmp/f1-11210/tc_netlink.c:416:
+ uint32_t flags = 0;
+ nl_attr_put32(&req->n, datalen, TCA_FLOWER_FLAGS, flags);
WARNING: C99 // comments do not match recommendation
#445: FILE: /tmp/f1-11210/tc_netlink.c:445:
+ // TODO: error handling and other actions (delete, replace, ...)
Report for zebra_dplane.c | 40 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #324: FILE: /tmp/f1-11210/zebra_dplane.c:324:
< WARNING: C99 // comments do not match recommendation
< #325: FILE: /tmp/f1-11210/zebra_dplane.c:325:
< WARNING: C99 // comments do not match recommendation
< #326: FILE: /tmp/f1-11210/zebra_dplane.c:326:
< WARNING: C99 // comments do not match recommendation
< #334: FILE: /tmp/f1-11210/zebra_dplane.c:334:
< WARNING: C99 // comments do not match recommendation
< #336: FILE: /tmp/f1-11210/zebra_dplane.c:336:
< WARNING: C99 // comments do not match recommendation
< #337: FILE: /tmp/f1-11210/zebra_dplane.c:337:
< WARNING: C99 // comments do not match recommendation
< #340: FILE: /tmp/f1-11210/zebra_dplane.c:340:
< WARNING: C99 // comments do not match recommendation
< #341: FILE: /tmp/f1-11210/zebra_dplane.c:341:
< WARNING: C99 // comments do not match recommendation
< #343: FILE: /tmp/f1-11210/zebra_dplane.c:343:
< WARNING: C99 // comments do not match recommendation
< #344: FILE: /tmp/f1-11210/zebra_dplane.c:344:
< WARNING: C99 // comments do not match recommendation
< #346: FILE: /tmp/f1-11210/zebra_dplane.c:346:
< WARNING: C99 // comments do not match recommendation
< #347: FILE: /tmp/f1-11210/zebra_dplane.c:347:
< ERROR: "foo * bar" should be "foo *bar"
< #1492: FILE: /tmp/f1-11210/zebra_dplane.c:1492:
< WARNING: line over 80 characters
< #1499: FILE: /tmp/f1-11210/zebra_dplane.c:1499:
< ERROR: "foo * bar" should be "foo *bar"
< #1499: FILE: /tmp/f1-11210/zebra_dplane.c:1499:
< WARNING: line over 80 characters
< #2386: FILE: /tmp/f1-11210/zebra_dplane.c:2386:
< WARNING: C99 // comments do not match recommendation
< #2795: FILE: /tmp/f1-11210/zebra_dplane.c:2795:
< ERROR: else should follow close brace '}'
< #3546: FILE: /tmp/f1-11210/zebra_dplane.c:3546:
< ERROR: Bad function definition - enum zebra_dplane_result dplane_tc_update() should probably be enum zebra_dplane_result dplane_tc_update(void)
< #3556: FILE: /tmp/f1-11210/zebra_dplane.c:3556:
< WARNING: C99 // comments do not match recommendation
< #5695: FILE: /tmp/f1-11210/zebra_dplane.c:5695:
Report for zebra_dplane.h | 8 issues
===============================================
< WARNING: line over 80 characters
< #390: FILE: /tmp/f1-11210/zebra_dplane.h:390:
< ERROR: "foo * bar" should be "foo *bar"
< #390: FILE: /tmp/f1-11210/zebra_dplane.h:390:
< WARNING: line over 80 characters
< #391: FILE: /tmp/f1-11210/zebra_dplane.h:391:
< ERROR: "foo * bar" should be "foo *bar"
< #391: FILE: /tmp/f1-11210/zebra_dplane.h:391:
CLANG Static Analyzer Summary
- Github Pull Request 11694, comparing to Git base SHA b993483
- Base image data for Git b993483 does not exist - compare skipped
3 Static Analyzer issues remaining.
See details at https://ci1.netdef.org/browse/FRR-PULLREQ2-6808/artifact/shared/static_analysis/index.html
Continuous Integration Result: SUCCESSFUL
Continuous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF / OpenSourceRouting.org CI System
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6826/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Warnings Generated during build:
Checkout code: Successful with additional warnings
<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
<stdin>:869: space before tab in indent.
break; /* should never hit here */
warning: 2 lines add whitespace errors.
Report for interface.c | 6 issues
===============================================
< ERROR: code indent should use tabs where possible
< #1582: FILE: /tmp/f1-31488/interface.c:1582:
< WARNING: please, no space before tabs
< #1582: FILE: /tmp/f1-31488/interface.c:1582:
< WARNING: please, no spaces at the start of a line
< #1582: FILE: /tmp/f1-31488/interface.c:1582:
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-31488/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-31488/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-31488/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-31488/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-31488/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-31488/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
CLANG Static Analyzer Summary
- Github Pull Request 11694, comparing to Git base SHA d40c814
- Base image data for Git d40c814 does not exist - compare skipped
3 Static Analyzer issues remaining.
See details at https://ci1.netdef.org/browse/FRR-PULLREQ2-6826/artifact/shared/static_analysis/index.html
Continuous Integration Result: SUCCESSFUL
Continuous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF / OpenSourceRouting.org CI System
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6827/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Warnings Generated during build:
Checkout code: Successful with additional warnings
<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
warning: 1 line adds whitespace errors.
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-13270/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-13270/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-13270/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-13270/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-13270/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-13270/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
CLANG Static Analyzer Summary
- Github Pull Request 11694, comparing to Git base SHA d40c814
- Base image data for Git d40c814 does not exist - compare skipped
3 Static Analyzer issues remaining.
See details at https://ci1.netdef.org/browse/FRR-PULLREQ2-6827/artifact/shared/static_analysis/index.html
Continuous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF / OpenSourceRouting.org CI System
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6856/
This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.
Warnings Generated during build:
Checkout code: Successful with additional warnings
<stdin>:726: trailing whitespace.
* 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5
warning: 1 line adds whitespace errors.
Report for pkt_cls.h | 24 issues
===============================================
ERROR: space prohibited before that close parenthesis ')'
#291: FILE: /tmp/f1-29229/pkt_cls.h:291:
+#define TCA_RSVP_MAX (__TCA_RSVP_MAX - 1 )
WARNING: line over 80 characters
#590: FILE: /tmp/f1-29229/pkt_cls.h:590:
+ TCA_FLOWER_KEY_CT_FLAGS_NEW = 1 << 0, /* Beginning of a new connection. */
WARNING: line over 80 characters
#591: FILE: /tmp/f1-29229/pkt_cls.h:591:
+ TCA_FLOWER_KEY_CT_FLAGS_ESTABLISHED = 1 << 1, /* Part of an existing connection. */
WARNING: line over 80 characters
#592: FILE: /tmp/f1-29229/pkt_cls.h:592:
+ TCA_FLOWER_KEY_CT_FLAGS_RELATED = 1 << 2, /* Related to an established connection. */
WARNING: line over 80 characters
#595: FILE: /tmp/f1-29229/pkt_cls.h:595:
+ TCA_FLOWER_KEY_CT_FLAGS_REPLY = 1 << 5, /* Packet is in the reply direction. */
ERROR: trailing whitespace
#720: FILE: /tmp/f1-29229/pkt_cls.h:720:
+ * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 $
Merged after approval during 8/16/2022 meeting