frr icon indicating copy to clipboard operation
frr copied to clipboard

bgpd: Cluster list attribute handling

Open ton31337 opened this issue 2 years ago • 12 comments

ton31337 avatar Jul 19 '22 11:07 ton31337

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 3 tests failed

_ _
Result SUCCESS git merge/11645 6061824f
Date 07/19/2022
Start 07:27:52
Finish 07:56:04
Run-Time 28:12
Total 1816
Pass 1813
Fail 3
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2022-07-19-07:27:52.txt
Log autoscript-2022-07-19-07:29:11.log.bz2
Memory 525 526 462

For details, please contact louberger

LabN-CI avatar Jul 19 '22 11:07 LabN-CI

@louberger can you look at the failures here so we can figure out how to fix them? :-)

riw777 avatar Jul 19 '22 12:07 riw777

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6557/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI avatar Jul 19 '22 13:07 NetDEF-CI

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 3 tests failed

_ _
Result SUCCESS git merge/11645 6061824f
Date 07/19/2022
Start 10:02:58
Finish 10:30:54
Run-Time 27:56
Total 1813
Pass 1810
Fail 3
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2022-07-19-10:02:58.txt
Log autoscript-2022-07-19-10:04:07.log.bz2
Memory 542 550 460

For details, please contact louberger

LabN-CI avatar Jul 19 '22 14:07 LabN-CI

ci:rerun ... not certain why this is failing

riw777 avatar Jul 26 '22 12:07 riw777

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6653/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI avatar Jul 26 '22 14:07 NetDEF-CI

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 3 tests failed

_ _
Result SUCCESS git merge/11645 6061824f
Date 07/26/2022
Start 11:26:08
Finish 11:54:07
Run-Time 27:59
Total 1813
Pass 1810
Fail 3
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2022-07-26-11:26:08.txt
Log autoscript-2022-07-26-11:27:21.log.bz2
Memory 531 552 459

For details, please contact louberger

LabN-CI avatar Jul 26 '22 15:07 LabN-CI

@louberger any help here

donaldsharp avatar Aug 02 '22 15:08 donaldsharp

waiting on @louberger to help us understand the ci failure ...

riw777 avatar Aug 09 '22 12:08 riw777

sorry for the delay on this one, it looks like it is actually changing some underlying behavior the test that is failing is in a CE/PE config and routes are not propagating to one of the CEs. I'll see if I can modify one of the existing topotests to fail in a similar fashion. it is also generating a bad update error (probably related) `CE-127.0.0.135> show bgp neighbor 127.0.0.133 BGP neighbor is 127.0.0.133, remote AS 64512, local AS 64512, internal link Local Role: undefined Remote Role: undefined Description: H127.0.0.133 Hostname: GW-127.0.0.133 BGP version 4, remote router ID 127.0.0.133, local router ID 127.0.0.135 BGP state = Established, up for 00:00:00 Last read 00:00:00, Last write 00:00:00 Hold time is 180 seconds, keepalive interval is 60 seconds Configured hold time is 180 seconds, keepalive interval is 60 seconds Configured conditional advertisements interval is 60 seconds Neighbor capabilities: 4 Byte AS: advertised and received Extended Message: advertised and received AddPath: IPv4 Unicast: RX advertised and received Long-lived Graceful Restart: advertised and received Address families by peer: Route refresh: advertised and received(old & new) Enhanced Route Refresh: advertised and received Address Family IPv4 Unicast: advertised and received Hostname Capability: advertised (name: H127.0.0.135,domain name: n/a) received (name: GW-127.0.0.133,domain name: n/a) Graceful Restart Capability: advertised and received Remote Restart timer is 120 seconds Address families by peer: none Graceful restart information: End-of-RIB send: End-of-RIB received: Local GR Mode: Helper* Remote GR Mode: Helper R bit: False N bit: False Timers: Configured Restart Time(sec): 120 Received Restart Time(sec): 120 IPv4 Unicast: F bit: False End-of-RIB sent: No End-of-RIB sent after update: No End-of-RIB received: No Timers: Configured Stale Path Time(sec): 360 Message statistics: Inq depth is 0 Outq depth is 0 Sent Rcvd Opens: 25 24 Notifications: 22 0 Updates: 21 24 Keepalives: 27 27 Route Refresh: 0 0 Capability: 0 0 Total: 95 75 Minimum time between advertisement runs is 1 seconds Update source is 127.0.0.135

For address family: IPv4 Unicast Update group 23, subgroup 23 Packet Queue length 0 Community attribute sent to this neighbor(all) 0 accepted prefixes

Connections established 23; dropped 22 Last reset 00:00:02, Notification sent (UPDATE Message Error/Attribute Length Error) Message received that caused BGP to send a NOTIFICATION: FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF 00990200 00005A40 01010250 02000040 03047F00 00868004 04000000 62400504 0000007B 8009047F 00008480 0A087F00 00857F00 0084C010 28000200 59000000 7B000203 E8000000 01000203 E8000000 0201037F 00008614 6A030C00 00000000 07180500 00180500 09180500 08180500 07180500 06180500 05180500 04180500 03180500 02180500 01 Internal BGP neighbor may be up to 255 hops away. Local host: 127.0.0.135, Local port: 37669 Foreign host: 127.0.0.133, Foreign port: 4313 Nexthop: 127.0.0.135 Nexthop global: :: Nexthop local: :: BGP connection: non shared network BGP Connect Retry Timer in Seconds: 120 Read thread: on Write thread: on FD used: 20

`

louberger avatar Aug 09 '22 15:08 louberger

🚧 Basic BGPD CI results: Partial FAILURE, 3 tests failed

Results table
_ _
Result SUCCESS git merge/11645 6061824f
Date 08/09/2022
Start 11:47:41
Finish 12:16:06
Run-Time 28:25
Total 1816
Pass 1813
Fail 3
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2022-08-09-11:47:41.txt
Log autoscript-2022-08-09-11:49:09.log.bz2
Memory 528 497 462

For details, please contact louberger

LabN-CI avatar Aug 09 '22 16:08 LabN-CI

Thanks, checking.

ton31337 avatar Aug 09 '22 19:08 ton31337

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TP4U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO6DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO5U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Topotests debian 10 amd64 part 5: Failed (click for details) Topotests debian 10 amd64 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO5DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 5: No useful log found
Topotests Ubuntu 18.04 i386 part 5: Failed (click for details) Topotests Ubuntu 18.04 i386 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO5U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TP1U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO6U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details) Topotests Ubuntu 18.04 i386 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO4U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 4: No useful log found
Topotests debian 10 amd64 part 4: Failed (click for details) Topotests debian 10 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO4DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 4: No useful log found
Topotests debian 10 amd64 part 1: Failed (click for details) Topotests debian 10 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO1DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 1: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO6U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 1: Failed (click for details) Topotests Ubuntu 18.04 i386 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/TOPO1U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 1: No useful log found
Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 2
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 9
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 2
  • Addresssanitizer topotests part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests debian 10 amd64 part 3
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 4
  • IPv4 protocols on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 7
  • Static analyzer (clang)
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 0
  • IPv4 ldp protocol on Ubuntu 18.04

CLANG Static Analyzer Summary

  • Github Pull Request 11645, comparing to Git base SHA 03efa83
  • Base image data for Git 03efa83 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at https://ci1.netdef.org/browse/FRR-PULLREQ2-6850/artifact/shared/static_analysis/index.html

NetDEF-CI avatar Aug 10 '22 17:08 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6855/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI avatar Aug 10 '22 18:08 NetDEF-CI

@louberger can you retest this PR?

ton31337 avatar Aug 18 '22 16:08 ton31337

@louberger ping :)

ton31337 avatar Sep 08 '22 14:09 ton31337