frr icon indicating copy to clipboard operation
frr copied to clipboard

More Babeld updates

Open jech opened this issue 2 years ago • 2 comments

@donaldsharp Thank you very much for https://github.com/FRRouting/frr/commit/db6d4c8375f32c11336f9542b558640c5c5915f2 . However, there's a couple of points that you appear to have missed:

  1. Unknown flag bits in Hello TLVs should be silently ignored; your code ignores the whole TLV. Please remove the conditional at https://github.com/FRRouting/frr/blob/master/babeld/message.c#L438
  2. All TLVs with unknown mandatory sub-TLVs must be ignored. This includes ACK_REQ, ACK, ROUTER_ID and NH. Please see the function parse_unknown_subtlv at https://github.com/jech/babeld/blob/master/message.c#L395

jech avatar Jun 10 '22 10:06 jech

Why don't you submit a PR here? If you know what to do then do it and I can get it in

donaldsharp avatar Jun 14 '22 14:06 donaldsharp

Donald, I'm maintaining the standalone babeld, and reviewing the patches that go into BIRD. I simply don't have the time or energy to be maintaining FRR's fork in addition to that. Sorry.

jech avatar Jun 21 '22 11:06 jech

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

github-actions[bot] avatar Jan 08 '23 01:01 github-actions[bot]

This issue will be automatically closed in the specified period unless there is further activity.

frrbot[bot] avatar Jan 08 '23 01:01 frrbot[bot]

Still relevant, please don't close.

jech avatar Jan 08 '23 02:01 jech

This issue will no longer be automatically closed.

frrbot[bot] avatar Jan 08 '23 02:01 frrbot[bot]

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

github-actions[bot] avatar Jul 25 '23 02:07 github-actions[bot]

This issue will be automatically closed in the specified period unless there is further activity.

frrbot[bot] avatar Jul 25 '23 02:07 frrbot[bot]

Still relevant.

jech avatar Jul 25 '23 02:07 jech

This issue will no longer be automatically closed.

frrbot[bot] avatar Jul 25 '23 02:07 frrbot[bot]