frr
frr copied to clipboard
More Babeld updates
@donaldsharp Thank you very much for https://github.com/FRRouting/frr/commit/db6d4c8375f32c11336f9542b558640c5c5915f2 . However, there's a couple of points that you appear to have missed:
- Unknown flag bits in Hello TLVs should be silently ignored; your code ignores the whole TLV. Please remove the conditional at https://github.com/FRRouting/frr/blob/master/babeld/message.c#L438
- All TLVs with unknown mandatory sub-TLVs must be ignored. This includes ACK_REQ, ACK, ROUTER_ID and NH. Please see the function parse_unknown_subtlv at https://github.com/jech/babeld/blob/master/message.c#L395
Why don't you submit a PR here? If you know what to do then do it and I can get it in
Donald, I'm maintaining the standalone babeld, and reviewing the patches that go into BIRD. I simply don't have the time or energy to be maintaining FRR's fork in addition to that. Sorry.
This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose
label in order to avoid having this issue closed.
This issue will be automatically closed in the specified period unless there is further activity.
Still relevant, please don't close.
This issue will no longer be automatically closed.
This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose
label in order to avoid having this issue closed.
This issue will be automatically closed in the specified period unless there is further activity.
Still relevant.
This issue will no longer be automatically closed.