Use a single consistent set of route types when resolving nexthops for NHT/reachability, and for routes' nexthops. The two paths were using different types when deciding whether a nexthop was resolved, and that doesn't make sense.

This is related to #10385 , see comments there for some more discussion about this area.

Feb 08 '22 17:02 mjstapp

I think I'll add some doc changes to zebra.rst to reflect the fact that this will be a change in behavior

Feb 08 '22 19:02 donaldsharp

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-3298/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-3298/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3298/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-3298/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3298/artifact/TOPO5U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-3298/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3298/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-3298/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3298/artifact/TOPO5U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-3298/test

Topology Tests failed for Topotests debian 10 amd64 part 1 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3298/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 5: No useful log found

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 1: No useful log found

Topotests debian 10 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5DEB10AMD64-3298/test

Topology Tests failed for Topotests debian 10 amd64 part 5 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-3298/artifact/TOPO5DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 2
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
Debian 10 deb pkg check
IPv6 protocols on Ubuntu 18.04
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 3
IPv4 protocols on Ubuntu 18.04
CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 6
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Debian 9 deb pkg check

Feb 08 '22 19:02 NetDEF-CI

clang-format seems to have a bug where a non indented case label will sometimes make it lose track of where blocks end; the style suggestions on this particular PR can be ignored

Feb 09 '22 16:02 qlyoung

converted to draft - still need some work to make this reliable/consistent

Mar 15 '22 14:03 mjstapp

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

Sep 12 '22 02:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Oct 13 '22 13:10 github-actions[bot]

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

Aug 02 '23 02:08 github-actions[bot]

frr
frr copied to clipboard

zebra: use consistent route types to resolve nexthops