Inconsistent local address output for show bfd peers brief command

[tomleb]

Describe the bug

The output of show bfd peers brief and show bfd peers brief json is inconsistent: their LocalAddress value differs.

• [x] Did you check if this is a duplicate issue?
• [ ] Did you test it on the latest FRRouting/frr master branch?

To Reproduce

Here's an example vtysh session where the local-address is configured for a BFD peer.

# config
(config)# bfd
(config-bfd)# peer 10.0.23.2 interface sw1p0 local-address 10.0.23.1
(config-bfd-peer)# end
# show bfd peers brief
Session count: 1
SessionId  LocalAddress                             PeerAddress                             Status         
=========  ============                             ===========                             ======         
1163777274 unknown                                  10.0.23.2                               down           

# show bfd peers brief json
[{"multihop":false,"peer":"10.0.23.2","local":"10.0.23.1",...]

As you can see, for the first command, LocalAddress is displayed as unknown but the second command correctly displays 10.0.23.2.

Expected behavior

The output of both command should be consistent for the local-address.

Versions

• OS Version: RHEL 8
• Kernel: 5.14
• FRR Version: 8.1

[ewlumpkin]

New pull request for fix with verbose commit message.

https://github.com/FRRouting/frr/pull/10519

[github-actions[bot]]

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

[frrbot[bot]]

This issue will be automatically closed in the specified period unless there is further activity.