preview-service icon indicating copy to clipboard operation
preview-service copied to clipboard

Published 20 hours ago • verified publisher icon FPurchess

update dependencies

Open wollanup opened this issue 2 years ago • 2 comments

wollanup avatar Dec 19 '22 13:12 wollanup

Hi @wollanup, thanks for your PR.

I realized that you removed the pinned versions. Pinning the version has a reason of having predictable, pre-tested software behaviour. Could you please pin them again?

FPurchess avatar Dec 19 '22 19:12 FPurchess

Hi @FPurchess .

I'm sorry, my goal was to make some changes and test on my fork befor submitting the PR. I'm more a gitlab guy now...

About the wildcard in pipfile, I thought the pinning mechanism was made by the lockfile ? Originally I wanted to update the preview service to latest version 0.29 to solve issues with PDF. I had many 500 before the update with some non-standard PDF, but it works now.

My experience in python is quite limited, I worked a bit with flask, pip and requirements.txt, never with pipenv, so I didn't know to update to the latest version without "unpinning" in the pipfile.

Another thing I would like to propose, is to change 500 response status status when file is not supported, or empty, and send back to the client some 422 or 400 statuses. What do you think ?

wollanup avatar Dec 20 '22 08:12 wollanup