Falco Peijnenburg comments

Results 38 comments of


                                            Falco Peijnenburg

Type signature on next line doesn't pass at all

Yes, it is. Hence the existence of this issue.

Type signature on next line doesn't pass at all

Sorry. I honestly don't understand what you meant to say. Did you mean to confirm that the test is incorrectly marked as passing?

Type signature on next line doesn't pass at all

I'll have to agree with you there. It's very difficult to do this correctly with regex.

Fix error when tmysql4 is preferred but not installed

Please note that MySQLite has its own repo: https://github.com/FPtje/mysqlite This is why the check-modified-subtree check fails.

Fix error when tmysql4 is preferred but not installed

> Do you want me to close this and make a PR in that repo instead? Or would you like me to make an identical PR in that repo as...

Fix error when tmysql4 is preferred but not installed

Looks good for a PR on the other repo. I'll take a closer look later :+1:

Fix error when tmysql4 is preferred but not installed

With the PR in MySQLite, I'm closing this PR. See https://github.com/FPtje/MySQLite/pull/16

Fixed overlapping of boxes

The boxes shouldn't be overlapping even before the pull request. Could there be some sort of font issue on your device that causes the box heights to be different for...

Fixed overlapping of boxes

Huh, I just installed GMod on Linux, and I can actually reproduce the overlapping boxes. Thanks for the fix! I'll test on both Windows and Linux to be sure.

Fixed overlapping of boxes

Works on both. Thanks for finding and solving this issue! Much appreciated.