FOSSBilling icon indicating copy to clipboard operation
FOSSBilling copied to clipboard

Use generatePassword rather than a shortened hash

Open BelleNottelling opened this issue 2 years ago • 1 comments

As the tin says. These are the only two spots I could find where the code was doing that. Eventually, we should update / rewrite the src/bb-modules/Client/Api/Guest.php->reset_password() function to use a password the user defines, but I think we should focus on that after we get the initial release out.

BelleNottelling avatar Oct 24 '22 20:10 BelleNottelling

Okay, I don't know why that test is failing. I guess I'll have to figure that out later

BelleNottelling avatar Oct 24 '22 20:10 BelleNottelling

I'm about to go to bed, I'll see if I can fix the tests tomorrow. Otherwise, this PR should be ready for reviews

BelleNottelling avatar Oct 25 '22 06:10 BelleNottelling

For some reason, the tests were having issues with client logins. The email address was becoming null. Testing outside of the test, it worked fine & the logic behaved correctly. In this commit, I switched back to using the older isEmailVaild test for just that. Tests pass now.

Test locally, I am able to create accounts, login, change emails, ect. So all seems to be working. Doing a squash merge. Will have to figure out that one test at a later date, but for now the email is still validated so it's not the end of the world

BelleNottelling avatar Oct 25 '22 09:10 BelleNottelling