fome-fw icon indicating copy to clipboard operation
fome-fw copied to clipboard

Multi-dimensional mapping improvements

Open 125jdavis opened this issue 2 years ago • 7 comments

Currently we have adder tables for VE, spark, and boost tables. In many cases a multiplying or blending (interpolation) would be the better and/or more intuitive approach, so allowing the user to select add/multiply/blend allows more flexibility.

Shown below is one potential approach for blending: image

Note that the axes of the authority table need not necessarily match the axes of the primary and secondary maps.

125jdavis avatar Sep 13 '23 22:09 125jdavis

@125jdavis @mck1117 guess this issue was intended for FOME firmware repo?

mi-hol avatar Sep 16 '23 21:09 mi-hol

Looks like it, thanks.

How hard is it to put a switch in that allows the adder table to either be an adder, or makes table 1 a full VE table? Or just make table one a full VE table and only 2-4 adders to satisfy those that want a full table switch, given it comes up a LOT.

OrchardPerformance avatar Sep 17 '23 17:09 OrchardPerformance

I like the switch approach. Additionally, one of the weaknesses of the current approach is that the bias parameter and the y-axis of the blend table must be the same. There are cases where they should not be the same.

125jdavis avatar Jan 15 '24 06:01 125jdavis

bias parameter and the y-axis of the blend table must be the same

This is...not true. The Y axis of the blend table is always the same as the Y axis of the table its blending (VE blends use VE table Y axis, etc), and the blend parameter is of course selectable.

mck1117 avatar Jan 15 '24 08:01 mck1117

Understood. So in order to make a switchable axis algorithm (i.e. SD at low load, TPS at high load) the y-axis of the blend table would need to be selectable.

125jdavis avatar Jan 17 '24 04:01 125jdavis

Yep, blend table axis should probably be selectable. Cases where it is needed are rare but it gives a huge gain in function.

The 1st blend curve should also probably be a 8x8 table instead of a curve so that first one can be used as a blend map with rpm acounted for. That then allows you to chose where in the rev range the blend is active.

OrchardPerformance avatar Jan 17 '24 05:01 OrchardPerformance

You can now pick many parameters as the Y axis: cde642ae6180e1e82664b08e5c0d7956ce53a8ef

mck1117 avatar Jan 17 '24 10:01 mck1117