ChRIS_ultron_backEnd Replace string regex with compiled regex

Replace string regex with compiled regex

Open jennydaman opened this issue 2 years ago • 9 comments

https://github.com/FNNDSC/ChRIS_ultron_backEnd/blob/3ee492dfa699b6394b19a6458fd511bda2824e09/chris_backend/plugins/serializers.py#L135

Apr 10 '22 17:04 jennydaman

Hi @jennydaman , please could I be assigned this issue to get a bit comfortable with the project?

Apr 17 '22 13:04 fortune-max

Screenshot 2022-04-17 at 16 21 05

Please could you look over this? Can I open a PR?

Apr 17 '22 15:04 fortune-max

Just thought about it, and if the intention is to reduce how often the Pattern is generated (before being matched) it may be better to make re_valid_version a class/not-a-local variable. Let me know your thoughts on this.

Apr 17 '22 15:04 fortune-max

Pull request here.

Apr 18 '22 18:04 fortune-max

Hey @jennydaman Can you please assign me this issue?

Sep 29 '22 15:09 Aman-Jamshed

Hi @jennydaman I am an outreachy candidate can you please assign this issue to me?

Oct 10 '22 10:10 sakshi1215

Ping @jennydaman if you missed the following 😄

Oct 11 '22 15:10 sakshi1215

@Aman-Jamshed due to inactivity, I have reassigned this issue to @sakshi1215

Oct 14 '22 10:10 jennydaman

Hi @jennydaman! I'm an Outreachy applicant for the summer 2023 round. I've setup the project repository, could you please assign me this issue?

Mar 09 '23 10:03 Ankita13-code

ChRIS_ultron_backEnd ChRIS_ultron_backEnd copied to clipboard

Replace string regex with compiled regex

ChRIS_ultron_backEnd
ChRIS_ultron_backEnd copied to clipboard