VineHelper icon indicating copy to clipboard operation
VineHelper copied to clipboard

[FR] Sort by known ETV

Open RealFakeGitter opened this issue 1 year ago • 5 comments

Feature Request: There is already a feature that displays the ETV once at item is clicked, which is great, for those items that the ETV has already been saved for it would be really cool if we can sort the searches based on that ETV low to high etc.

RealFakeGitter avatar Mar 21 '24 18:03 RealFakeGitter

That seems to be solved as the etv is now automatically fetched. That is even better than what I proposed with using a third party service. @FMaz008 could you share the committee where this is implemented?

Wladefant avatar Jan 17 '25 12:01 Wladefant

Additionally @FMaz008 the feature where you share the etv is not needed anymore as all etv are provided Screenshot_20250118_083942_Yandex Browser.jpg

When the etv is automatically fetched the extension does not seem to understand it and fetch from the user

Wladefant avatar Jan 18 '25 07:01 Wladefant

20250118_091416.jpg

All right maybe I was wrong, probably someone created a bot that clicks on see details?

That is why I didn't find the commit, it was really great 🙂.

I would really propose getting the price through a third party service with an api for the products. They are quite cheap and improves the life of viners substantially instead of always clicking

Wladefant avatar Jan 18 '25 08:01 Wladefant

You are not gonna get etv=0 information through third party, right?

hutauf avatar Jan 18 '25 08:01 hutauf

Yeah that is unfortunat4ly not possible price does not equal etv but until there is not etv price will suffice. That should be of course a different label, a dollar sign or something instead of etv

Wladefant avatar Jan 18 '25 08:01 Wladefant

Seems I missed this discussion entirely before today.

In short:

  • No the ETV is not automatically fetched.
  • No, a 3rd party API would not allow me to get ETV values.
  • Yes, a 3rd party API would allow me to get the price for the item, but the cost for the amount of items VH handles would be significant. It's on my list to look into it at some point though.
  • As I understand the initial request was asking to sort by ETV, which is now possible in the notification monitor. I'll close this issue.

FMaz008 avatar May 26 '25 14:05 FMaz008