mdk icon indicating copy to clipboard operation
mdk copied to clipboard

Improve version.php script (do not prompt for upgrade after running it)

Open marinaglancy opened this issue 6 years ago • 3 comments

  • do not accidentally bump the core version up
  • if we downgraded any plugins or core and moodle does not need upgrade, update the verison hash This way we won't need to run upgrade script after fixing version

marinaglancy avatar Oct 23 '19 11:10 marinaglancy

Thanks Marina.

Have you considered simply running:

mdk run version; mdk upgrade --no-checkout

FMCorz avatar Oct 24 '19 11:10 FMCorz

I run this script on non-mdk installations so it was convenient for me if it does everything out-of-the-box. But if you think it's not needed, ignore this pull request

marinaglancy avatar Dec 10 '19 14:12 marinaglancy

also my change to line 33 was a bug imho

marinaglancy avatar Dec 10 '19 14:12 marinaglancy