fix-orchestra icon indicating copy to clipboard operation
fix-orchestra copied to clipboard

[repository schema] Some simple types are not used.

Open francescoloconte opened this issue 2 years ago • 2 comments

The following types are defined in the schema but they do not seem to be used anywhere:

<xs:simpleType name="CategoryComponentType_t"> <xs:restriction base="xs:string"> <xs:enumeration value="Field"/> <xs:enumeration value="Message"/> </xs:restriction> </xs:simpleType>

<xs:simpleType name="CompID_t"> <xs:restriction base="xs:positiveInteger"> <xs:minInclusive value="1000"/> </xs:restriction> </xs:simpleType>

<xs:simpleType name="GroupName_t"> <xs:restriction base="xs:string"/> </xs:simpleType>

<xs:simpleType name="IncludeFile_t"> <xs:restriction base="xs:string"> <xs:enumeration value="components"/> <xs:enumeration value="fields"/> </xs:restriction> </xs:simpleType>

francescoloconte avatar Nov 20 '23 22:11 francescoloconte

@kleihan , if these simple types are not used in the schema, is this a sufficient reason to remove them? Or can there be other reasons for which they should remain even if not used? There may be aspects of the standard am I not familiar with, that justify these staying in the schema. If you confirm they can be removed, I would submit a PR to remove them, and close this ticket.

francescoloconte avatar Aug 16 '24 04:08 francescoloconte

I can confirm that these are all unused, likely vestigial from Unified, and concur they can be removed.

patricklucas avatar Sep 06 '24 14:09 patricklucas