fix-orchestra icon indicating copy to clipboard operation
fix-orchestra copied to clipboard

[repository schema] Some categoryType's attributes should be required.

Open francescoloconte opened this issue 2 years ago • 2 comments

The categoryType doesn’t have any required attributes. Seems like the name attribute should be marked as required, and maybe componentType too. For example, in FIX Basic XML format, the name, FIXMLFileName, and componentType are marked as required. The same issue found in sectionType.

image

francescoloconte avatar Oct 21 '23 02:10 francescoloconte

It would be useful to get feedback from the community about this change. Lacking that, @kleihan , what's your thoughts about this? If you supported it, I would create a PR for this. It would make the name and componentType attributes mandatory for both the categoryType and sectionType.

francescoloconte avatar Aug 16 '24 05:08 francescoloconte

Visualisation tools like FIXimate use section and category for message navigation, so I agree it makes sense to make certain fields required.

Proposal

  • Make name and section required attributes for categoryType.
  • Make name a required attribute for sectionType.

I do not think we need to make the componentType attribute a required field, as in practice, I have only ever seen it set to "Message". I'd be interested to know if anyone has a valid use case for using "Field".

Note: I have proposed the removal of the componentType attribute in issue #93.

martinswanson avatar Sep 10 '24 16:09 martinswanson