herd icon indicating copy to clipboard operation
herd copied to clipboard

FactoryCQ - Remove CRED_PROXY and CRED_PORT environment variables

Open nateiam opened this issue 7 years ago • 0 comments

Please eliminate recently added CRED_PROXY and CRED_PORT environment variables from Herd’s “credstash” wrapper code

Instead, the “credstash” wrapper should use HTTP_PROXY_HOST and HTTP_PROXY_PORT values from the already existing Herd configurations utilizing ConfigurationHelper class.

-Please also add an INFO log entry to the “credstash” wrapper to output the proxy setting (if any) being actually used to communicate with AWS.-

Acceptance Criteria:

Delete "org.finra.herd.service.credstash.EnvConfig" class and instead make JCredStashWrapper to use -(and log)- ConfigurationHelper's HTTP_PROXY_HOST and HTTP_PROXY_PORT values.

nateiam avatar May 13 '17 20:05 nateiam