JTAF-ExtWebDriver icon indicating copy to clipboard operation
JTAF-ExtWebDriver copied to clipboard

Published 20 hours ago • verified publisher icon FINRAOS

Allow a default locator to be set for String locators

Open SMxJrz opened this issue 10 years ago • 5 comments

With recent changes made to improve performance we should allow the setting of a default locator so that we people using the pre-existing locator constructors can get the most out of these changes (they can still have the ability to change locator for each widget by just providing the locator type)

SMxJrz avatar Aug 08 '14 21:08 SMxJrz

I would guess that you can a lot of such work with find and replace. So don't put more stuff for backward compatibility into the code base.

opensource21 avatar Aug 13 '14 12:08 opensource21

There are 50+ projects that would need to find and replace :-) This is worth having a discussion with the team.

kood1 avatar Aug 13 '14 16:08 kood1

Well it was 50+ project which can live with the performance before. Defining a default, will ends in trouble too, if it's not always the same. Making to much compromises for the 50+ projects make it difficult to win the next 100+ projects. If it's really necessary make it with a system-property so that only 1 class is affected. I would guess that the project for which it is useful use xpath-expression. In this case the performance issue is small. Only projects which mixed locator have an advantage and there it's hard work you must invest.

opensource21 avatar Aug 13 '14 19:08 opensource21

I don't see it being a too much an issue in adding this feature since the new projects will know the legacy constructor is discouraged, hence they won't really use this feature. The existing projects can have this in place until they migrate over. I don't think the work that needs to be done to implement this and later removing won't be too difficult.

Any other thoughts from the team?

kood1 avatar Aug 13 '14 19:08 kood1

Again I have doubt about the value of this feature. If it only affect the default constructor and don't end in new method in Session or Element it's not a big problem.

2014-08-13 21:20 GMT+02:00 Daniel Koo [email protected]:

I don't see it being a too much an issue in adding this feature since the new projects will know the legacy constructor is discouraged, hence they won't really use this feature. The existing projects can have this in place until they migrate over. I don't think the work that needs to be done to implement this and later removing won't be too difficult.

Any other thoughts from the team?

— Reply to this email directly or view it on GitHub https://github.com/FINRAOS/JTAF-ExtWebDriver/issues/73#issuecomment-52097028 .

opensource21 avatar Aug 13 '14 19:08 opensource21