PMD issues for class org.finra.jtaf.ewd.session.SessionManager

[mmlinford]

The following issues were found in org.finra.jtaf.ewd.session.SessionManager when running PMD:

[INFO] PMD Failure: org\finra\jtaf\ewd\session\SessionManager.java:34 Rule:ClassWithOnlyPrivateConstructorsShouldBeFinal Priority:1 A class which only has private constructors should be final. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:36 Rule:ImmutableField Priority:3 Private field 'sessions' could be made final; it is only initialized in the declaration or constructor.. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:43 Rule:LongVariable Priority:3 Avoid excessively long variable names like nextCustomSessionId. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:51 Rule:AvoidFieldNameMatchingTypeName Priority:3 It is somewhat confusing to have a field name matching the declaring class name. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:52 Rule:AvoidSynchronizedAtMethodLevel Priority:3 Use block level rather than method level synchronization. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:58 Rule:AvoidSynchronizedAtMethodLevel Priority:3 Use block level rather than method level synchronization. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:115 Rule:UselessParentheses Priority:4 Useless parentheses.. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:115 Rule:UselessParentheses Priority:4 Useless parentheses.. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:119 Rule:AvoidCatchingGenericException Priority:3 Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:122 Rule:AvoidInstanceofChecksInCatchClause Priority:3 An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:123 Rule:AvoidPrintStackTrace Priority:3 Avoid printStackTrace(); use a logger call instead.. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:231 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:247 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:269 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:293 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:317 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:336 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:348 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:356 Rule:ShortVariable Priority:3 Avoid variables with short names like dc. [INFO] PMD Failure: org.finra.jtaf.ewd.session.SessionManager:383 Rule:ShortVariable Priority:3 Avoid variables with short names like id.